Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api-diff between 7.0-preview7 and 7.0-rc1 #7808

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

carlossanlop
Copy link
Member

If you see unusual diffs in this PR, please help fixing them via suggestions. I would greatly appreciate it.

ASP.NET: https://github.com/orgs/dotnet/teams/aspnet-api-review
WinForms: @merriemcgaw @RussKie @JeremyKuhne
WPF: @singhashish-wpf and @pchaurasia14
Libraries: @danmoseley @jeffhandley @karelz @ericstj @stephentoub

@dotnet/area-microsoft-win32
@dotnet/area-system-buffers
@dotnet/area-system-componentmodel
System.Data @ajcvickers @DavoudEshtehari @David-Engel
System.Diagnostics @tommcdon
@dotnet/area-system-formats-asn1
@dotnet/area-system-io
@dotnet/area-system-linq
System @dotnet/area-system-runtime
System.Net* @dotnet/ncl
@dotnet/area-system-numerics
@dotnet/area-system-reflection-emit
@dotnet/area-system-reflection
System.Runtime.InteropServices @dotnet/interop-contrib
@dotnet/area-system-runtime
System.Runtime.Serialization @HongGit @StephenMolloy
System.Runtime.Versioning @buyaa-n

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes in my areas LGTM. CC. @dakersnar

Mostly just the nullability annotation fixes

@JeremyKuhne
Copy link
Member

@KlausLoeffelmann can you sanity check the WinForms changes you made here? Thanks!

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New WinForms CommandBinding and DataContext APIs look OK.

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Windows.Forms.* look good 👍

@KlausLoeffelmann @dreddy-work to confirm

Copy link

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Data looks good.

@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 20, 2022

System.Runtime.Versioning, System.Reflection, System.Reflection.Emit
changes LGTM

Comment on lines 34 to 36
- public HMACMD5();
+ [UnsupportedOSPlatformAttribute("browser")]
+ public HMACMD5();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The methods shouldn't show as deleted.

Suggested change
- public HMACMD5();
+ [UnsupportedOSPlatformAttribute("browser")]
+ public HMACMD5();
+ [UnsupportedOSPlatformAttribute("browser")]
public HMACMD5();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not showing up as deleted. AsmDiff shows the whole API as diffed when a new attribute decorates it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as with classes dotnet/arcade#10982

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not showing up as deleted.

On net, it isn't, no. But to a casual interpretation by a human, it is, since there's a - line for it.

@bartonjs
Copy link
Member

The content of System.Security.* and System.Formats.Asn1 looks correct to me; but the attribute-only changes are showing as very noisy diffs, suggesting we removed a lot of methods. Those diffs really need to be cleaned up.

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Text.Json & System.Linq changes LGTM

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Text.Json LGTM

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Diagnostics LGTM

@carlossanlop
Copy link
Member Author

@bartonjs I can apply your suggestions for APIs that only had their attributes changed, but note that this is something that affects many APIs and has been happening with AsmDiff for a long time. I really don't think this is worthy of this much attention and the priority seems low.

@carlossanlop carlossanlop merged commit c5f7b72 into dotnet:main Sep 22, 2022
@carlossanlop carlossanlop deleted the ApiDiffRC1 branch September 22, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.