Enhance Lockout Functionality: Add Test for AccessFailedAsync Incrementing Count #60350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-identity
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @shethaadit. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Identity/Extensions.Core/src/UserManager.cs:1833
- Add a test to cover the scenario where Options.Lockout.DefaultLockoutTimeSpan is TimeSpan.MaxValue to ensure the lockout end date is set correctly.
if (Options.Lockout.DefaultLockoutTimeSpan == TimeSpan.MaxValue)
shethaadit
requested review from
Rick-Anderson,
tdykstra and
a team
as code owners
Rick-Anderson
approved these changes
Feb 13, 2025
Co-authored-by: Rick Anderson <[email protected]>
Co-authored-by: Rick Anderson <[email protected]>
|
Hi @Rick-Anderson, @tdykstra, I committed changes according to suggestions. Could you please review again? Can you also help fixing build issue? Seems something from platform side. .dotnet\sdk\10.0.100-preview.2.25102.3\NuGet.targets(175,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot create a file when that file already exists. |
added 2 commits
February 18, 2025 14:08
…shethaadit/FixBug60181
…t/aspnetcore into shethaadit/FixBug60181
Hi @Rick-Anderson, @tdykstra, can you please review? |
Rick-Anderson
approved these changes
Feb 18, 2025
Rick-Anderson
approved these changes
Feb 18, 2025
added 2 commits
February 20, 2025 11:37
…shethaadit/FixBug60181
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Lockout Functionality: Add Test for
AccessFailedAsyncIncrementing CountPR Description:
This PR enhances the test coverage of the lockout functionality in
UserManagerTest.csby adding a new test case:AccessFailedAsync_IncrementsAccessFailedCountAccessFailedAsynccorrectly increments the access failed count for a user.Mock<IUserLockoutStore<PocoUser>>to simulate the behavior of the underlying store.This change improves reliability by validating that lockout mechanisms work as expected, aligning with best practices in identity management.
Testing:
Fixes #60181