Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTPS] Support exporting the dev-cert in PEM format and support importing an existing dev-cert in PFX #23567

Merged
merged 8 commits into from
Jul 7, 2020
Merged

[HTTPS] Support exporting the dev-cert in PEM format and support importing an existing dev-cert in PFX #23567

merged 8 commits into from
Jul 7, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jul 1, 2020 •
edited
Loading

  • Supports exporting the certificate in PEM format for use within tye, kubernetes, and other tools that don't support PFX.
  • Supports importing an existing valid dev-certificate into a given environment.
    • Importing requires that no valid certificate is present.
    • The goal is to more easily share the dev-cert from the host with WSL.

Open questions

  • Confirm PBE parameters.
  • Add additional tests
  • Validate UI

@javiercn javiercn marked this pull request as ready for review July 1, 2020 18:12
@javiercn javiercn requested a review from Tratcher July 1, 2020 18:12
@Pilchie Pilchie added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Jul 1, 2020
@javiercn javiercn force-pushed the javiercn/dev-certs-pem-support branch from 62a9158 to cde0462 Compare July 1, 2020 22:43
@javiercn javiercn force-pushed the javiercn/dev-certs-pem-support branch from df171eb to a7c2342 Compare July 7, 2020 12:41
@javiercn javiercn merged commit 156023d into master Jul 7, 2020
@javiercn javiercn deleted the javiercn/dev-certs-pem-support branch July 7, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campersau campersau campersau left review comments

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiercn @Tratcher @campersau @Pilchie