Consume the internalized System.Net.Quic sources #19156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Feb 19, 2020
|
|
||
| OperatingSystem ver = Environment.OSVersion; | ||
|
|
||
| if (ver.Platform == PlatformID.Win32NT && ver.Version < new Version(10, 0, 19041, 0)) |
There was a problem hiding this comment.
This check fails in our repo.
There was a problem hiding this comment.
@scalablecory this is something we'll need to revisit. Environment.OSVersion is extremely unreliable and shouldn't be used in production code. I'll file an issue.
jkotalik
approved these changes
Feb 19, 2020
|
@Tratcher is this ready to go? If so please merge |
|
@wtgodbe this is now ready to merge but the branch is restricted. Please merge. |
Tratcher
added a commit
that referenced
this pull request
Feb 20, 2020
* Consume the internalized System.Net.Quic sources * More changes from rebase * Remove Console.WriteLine
Merged
ghost
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Consume the internalized System.Net.Quic sources (#19156) * Consume the internalized System.Net.Quic sources * More changes from rebase * Remove Console.WriteLine * Additional code sync
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors dotnet/runtime#32549.
@scalablecory I've also pulled in your most recent changes to the shared sources. See the second commit. Fixes #18943
@jkotalik Please help me run a sanity test with MSQuic.