Update outdated npm dependencies

[mkArtakMSFT]

Description

The Angular project template are currently producing an error during project start.

Customer Impact

Starting new Angular SPA projects produces a red lined error in console, while still being runnable.

Regression?

No. This is not something we have control over so our approach here is always reactive.

Risk

Low. The change has been validated manually and the apps can be run successfully.

Addresses https://github.com/aspnet/AspNetCore-ManualTests/issues/43

[javiercn]

Is there no requirement to update the package.json files themselves?

[mkArtakMSFT]

@javiercn I just run 'npm update' and 'npm audit fix' and it does the right thing. So seems there were no required changes to the package.json

[ryanbrandenburg]

This seems fine, the packages which were removed from package.json seem to still be brought into package.lock.json transitively, so we didn't really lose anything.

[mkArtakMSFT]

@ryanbrandenburg, @javiercn here what I've done.

• I first tried to simply do npm update / install but it seems there is some dependency version which got updated and it started to bring in one after another a lot of dependencies.
• In the end, I just upgraded everything to the most recent available major version (refering to npm packages here)
• I've validated all projects (Angular, React, ReactRedux) by creating a new project, applying these changes to them and running. I was able to successfully validate all the pages.
• I've also run npm run lint on the ClientApp folder and it is running successfully for all these three projects

One thing I just now thought about is that I haven't validated anything with auth enabled. So maybe there are things to be done there. Not sure that can cause a problem or not. Please suggest.

[javiercn]

@mkArtakMSFT The tests are not uber-complete but they test enough stuff I think. They essentially click fetch data and go through the login process and validate that the user authorizes successfully.

For a simple dependency update there should be not much issue.

[mkArtakMSFT]

@javiercn, @ryanbrandenburg I am now slowly concluding that this is more like a test issue.
As part of my last verification I've downloaded the generated packages as part of the above failed builds, and created a new identity-enabled react project and manually run through it. Everything works!

[ryanbrandenburg]

@mkArtak looks like you needed some using's.

[mkArtakMSFT]

Talked to @ryanbrandenburg regarding this and from his experience it may be that the test looking for the fetch-data doesn't wait enough. So I'm validating that now with my last commit if that turns out to be the case, will simply increase the timeout.

[javiercn]

@mkArtakMSFT I don't think that's the case. By default tests now wait 2 minutes before the first assertion fails, and 30 seconds for the next assertion. If you don't have multiple failing tests, it's unlikely you are hitting a timeout.

[ryanbrandenburg]

Yeah, given that browser.Contains already does retries I suspect @javiercn is right.

[javiercn]

@mkArtakMSFT lets look at this together tomorrow

[mkArtakMSFT]

I've ended up reverting the React related changes to avoid the headache. We'll deal with it separately. for now making only Angular -targeted fix.

[mkArtakMSFT]

After re-validating it seems the issue is not that bad. The app still works, while producing the error.

[mkArtak]

I think I found the reason for the last couple of failures. It's a react issue being tracked svg/svgo#1174

[javiercn]

Merge this ASAP :)