Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Blazor SDK lost all feature switch settings causing a size regression #25099

Closed
eerhardt opened this issue Aug 20, 2020 · 0 comments
Closed

Latest Blazor SDK lost all feature switch settings causing a size regression #25099

eerhardt opened this issue Aug 20, 2020 · 0 comments
Assignees
@pranavkm
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
5.0.0-rc1

Comments

@eerhardt
Copy link
Member

eerhardt commented Aug 20, 2020 •
edited
Loading

Describe the bug

The latest Blazor SDK is not setting the linker feature switch settings that were added in #23987. This is causing the IL size to regress from ~2.2MB before to ~2.8MB (uncompressed)

To Reproduce

  1. Install the latest 5.0 SDK - 5.0.100-rc.1.20420.7.
  2. dotnet new blazorwasm
  3. dotnet publish -c Release

Inspect the publshed assemblies - especially System.Private.CoreLib.

Expected results

In previous builds, System.Private.CoreLib was around 1.2 MB uncompressed.

Actual results

In the latest build, System.Private.CoreLib is about 1.6 MB uncompressed.

Further technical details

  • ASP.NET Core version
  • Include the output of dotnet --info
.NET SDK (reflecting any global.json):
 Version:   5.0.100-rc.1.20420.7
 Commit:    3232fe7ac1

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19041
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\5.0.100-rc.1.20420.7\

Host (useful for support):
  Version: 5.0.0-rc.1.20417.14
  Commit:  907f7da59b
  • The IDE (VS / VS Code/ VS4Mac) you're running on, and it's version

cc @pranavkm
pranavkm added a commit that referenced this issue Aug 20, 2020
@pranavkm
Default new runtime feature switches
491a1b0 
Porting #23932 to WebAssemblySDK.

* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fixes #25099

If there is an ask mode template to fill out, let me know and I can do it.
@pranavkm pranavkm mentioned this issue Aug 20, 2020
Merged
@pranavkm pranavkm added the area-blazor Includes: Blazor, Razor Components label Aug 21, 2020
@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Aug 21, 2020
@pranavkm pranavkm added bug This issue describes a behavior which is not expected - a bug. Working labels Aug 21, 2020
@pranavkm pranavkm self-assigned this Aug 21, 2020
pranavkm added a commit that referenced this issue Aug 21, 2020
@pranavkm
Default new runtime feature switches
a2b535e 
Porting #23932 to WebAssemblySDK.

* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fixes #25099

If there is an ask mode template to fill out, let me know and I can do it.
ghost pushed a commit that referenced this issue Aug 22, 2020
@pranavkm
Default new runtime feature switches (#25108)
85835c7 
Porting #23932 to WebAssemblySDK.

* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fixes #25099

If there is an ask mode template to fill out, let me know and I can do it.
@ghost ghost added Done This issue has been fixed and removed Working labels Aug 24, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
5.0.0-rc1
Development

No branches or pull requests
2 participants
@pranavkm @eerhardt