Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Microsoft.Extensions.* CLS compliant #1716

Closed
NKnusperer opened this issue Aug 15, 2016 · 4 comments
Closed

Make Microsoft.Extensions.* CLS compliant #1716

NKnusperer opened this issue Aug 15, 2016 · 4 comments

Comments

@NKnusperer
Copy link

NKnusperer commented Aug 15, 2016

Is there any reason why they are not marked with CLSCompliant(true) ?
As far as I have looked through the projects non of theme are using suspicious types which are not compliant.

@Tratcher
Copy link
Member

We're considering it for the v1.1 milestone.

@NKnusperer
Copy link
Author

v1.1 is now out but looks like nothing has changed.

@jopabe
Copy link

jopabe commented Jun 7, 2017

Second this. We're starting to standardize on the Logging, DependencyInjection, Configuration and Options libraries for full .NET projects as well, but right now that requires marking all our software as CLSCompliant(false) (FxCop doesn't like omitting the attribute at all).
As these libraries support full .NET framework, it makes sense for them to comply with established standards/conventions as coded into static analysis tools where possible - especially here as there seems to be no downside.

Thanks for considering!

@aspnet-hello
Copy link

This issue is being closed because it has not been updated in 3 months.

We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants