Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TargetPlatform from Tfm only for frameworks older than net5.0 #6479

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Remove TargetPlatform from Tfm only for frameworks older than net5.0 #6479

merged 4 commits into from
Nov 3, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Oct 28, 2020 •
edited
Loading

  • adding regex to remove targetplatforms in targetframeworks for restore for older frameworks.
  • adding regex to remove targetplatform in tfm for build on older frameworks.

@ViktorHofer
Copy link
Member

Add code comments to describe the why and the what?

@Anipik Anipik mentioned this pull request Oct 28, 2020
Merged
@Anipik
Copy link
Contributor Author

Anipik commented Nov 2, 2020

@ViktorHofer @safern @ericstj this is ready for merge, can you guys take a look ?

ViktorHofer
ViktorHofer approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in as soon as possible as you already updated the Windows-NT platform to windows in dotnet/runtime. I'm sure something is already broken because of this, hence let's get this in fast.

safern
safern approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anipik Anipik merged commit b5b61c1 into dotnet:master Nov 3, 2020
@Anipik Anipik deleted the moniker branch November 3, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anipik @ViktorHofer @ericstj @safern