[Xamarin.Android.Build.Tasks] remove $(_InstantRunEnabled) checks

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Designer.targets

@@ -99,8 +99,7 @@ Copyright (C) 2016 Xamarin. All rights reserved.
       FrameworkDirectories="$(_XATargetFrameworkDirectories);$(_XATargetFrameworkDirectories)Facades"
       AcwMapFile="$(_AcwMapFile)"
       SupportedAbis="$(_BuildTargetAbis)"
-      SupportedOSPlatformVersion="$(SupportedOSPlatformVersion)"
-      InstantRunEnabled="$(_InstantRunEnabled)">
+      SupportedOSPlatformVersion="$(SupportedOSPlatformVersion)">
   </GenerateJavaStubs>
   <ManifestMerger
       Condition=" '$(AndroidManifestMerger)' == 'manifestmerger.jar' "
@@ -137,8 +136,7 @@ Copyright (C) 2016 Xamarin. All rights reserved.
       EnableSGenConcurrent="$(AndroidEnableSGenConcurrent)"
       SupportedAbis="$(_BuildTargetAbis)"
       AndroidPackageName="$(_AndroidPackage)"
-      EnablePreloadAssembliesDefault="$(_AndroidEnablePreloadAssembliesDefault)"
-      InstantRunEnabled="$(_InstantRunEnabled)">
+      EnablePreloadAssembliesDefault="$(_AndroidEnablePreloadAssembliesDefault)">
   </GeneratePackageManagerJava>
 </Target>
 

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Javac.targets

@@ -45,8 +45,7 @@ It is shared between "legacy" binding projects and .NET 7+ projects.
         JavaLibraries="@(AndroidJavaLibrary);@(EmbeddedJar)"
         ExternalJavaLibraries="@(AndroidExternalJavaLibrary)"
         LibraryProjectJars="@(ExtractedJarImports)"
-        DoNotPackageJavaLibraries="@(_ResolvedDoNotPackageAttributes)"
-        EnableInstantRun="$(_InstantRunEnabled)">
+        DoNotPackageJavaLibraries="@(_ResolvedDoNotPackageAttributes)">
       <Output TaskParameter="JavaLibrariesToCompile" ItemName="_BindingJavaLibrariesToCompile" />
       <Output TaskParameter="ReferenceJavaLibraries" ItemName="_ReferenceJavaLibs" />
     </DetermineJavaLibrariesToCompile>
@@ -60,15 +59,13 @@ It is shared between "legacy" binding projects and .NET 7+ projects.
         JavaLibraries="@(AndroidJavaLibrary)"
         ExternalJavaLibraries="@(AndroidExternalJavaLibrary)"
         LibraryProjectJars="@(ExtractedJarImports)"
-        DoNotPackageJavaLibraries="@(_ResolvedDoNotPackageAttributes)"
-        EnableInstantRun="$(_InstantRunEnabled)">
+        DoNotPackageJavaLibraries="@(_ResolvedDoNotPackageAttributes)">
       <Output TaskParameter="JavaLibrariesToCompile" ItemName="_JavaLibrariesToCompile" />
       <Output TaskParameter="ReferenceJavaLibraries" ItemName="_ReferenceJavaLibs" />
     </DetermineJavaLibrariesToCompile>
 
     <ItemGroup>
-      <_JavaLibrariesToCompileForApp Include="@(_JavaLibrariesToCompile)" Condition=" '$(_InstantRunEnabled)' != 'True' " />
-      <AndroidExternalJavaLibrary    Include="@(_JavaLibrariesToCompile)" Condition=" '$(_InstantRunEnabled)' == 'True' " />
+      <_JavaLibrariesToCompileForApp Include="@(_JavaLibrariesToCompile)" />
     </ItemGroup>
   </Target>
 
@@ -168,7 +165,7 @@ It is shared between "legacy" binding projects and .NET 7+ projects.
         JavaSourceFiles="@(_JavaSource)"
         ToolPath="$(JavacToolPath)"
         ToolExe="$(JavacToolExe)"
-        Jars="@(_JavaLibrariesToCompile);@(_InstantRunJavaReference);@(_ReferenceJavaLibs)"
+        Jars="@(_JavaLibrariesToCompile);@(_ReferenceJavaLibs)"
         JavacTargetVersion="$(JavacTargetVersion)"
         JavacSourceVersion="$(JavacSourceVersion)"
         IntermediateOutputPath="$(IntermediateOutputPath)"

src/Xamarin.Android.Build.Tasks/Tasks/DetermineJavaLibrariesToCompile.cs

@@ -16,8 +16,6 @@ public class DetermineJavaLibrariesToCompile : AndroidTask
 		[Required]
 		public ITaskItem[] MonoPlatformJarPaths { get; set; }
 
-		public bool EnableInstantRun { get; set; }
-
 		public ITaskItem[] JavaSourceFiles { get; set; }
 
 		public ITaskItem[] JavaLibraries { get; set; }
@@ -37,8 +35,7 @@ public class DetermineJavaLibrariesToCompile : AndroidTask
 		public override bool RunTask ()
 		{
 			var jars = new List<ITaskItem> ();
-			if (!EnableInstantRun)
-				jars.AddRange (MonoPlatformJarPaths);
+			jars.AddRange (MonoPlatformJarPaths);
 			if (JavaSourceFiles != null)
 				foreach (var jar in JavaSourceFiles.Where (p => Path.GetExtension (p.ItemSpec) == ".jar"))
 					jars.Add (jar);

src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs

@@ -73,7 +73,6 @@ public class GenerateJavaStubs : AndroidTask
 
 		public bool EmbedAssemblies { get; set; }
 		public bool NeedsInternet   { get; set; }
-		public bool InstantRunEnabled { get; set; }
 
 		public bool ErrorOnCustomJavaObject { get; set; }
 
@@ -336,7 +335,6 @@ IList<string> MergeManifest (NativeCodeGenState codeGenState, Dictionary<string,
 				Debug = Debug,
 				MultiDex = MultiDex,
 				NeedsInternet = NeedsInternet,
-				InstantRunEnabled = InstantRunEnabled
 			};
 			// Only set manifest.VersionCode if there is no existing value in AndroidManifest.xml.
 			if (manifest.HasVersionCode) {

src/Xamarin.Android.Build.Tasks/Tasks/GeneratePackageManagerJava.cs

@@ -61,9 +61,6 @@ public class GeneratePackageManagerJava : AndroidTask
 		[Required]
 		public bool EnablePreloadAssembliesDefault { get; set; }
 
-		[Required]
-		public bool InstantRunEnabled { get; set; }
-
 		public bool EnableMarshalMethods { get; set; }
 		public string RuntimeConfigBinFilePath { get; set; }
 		public string BoundExceptionType { get; set; }
@@ -334,7 +331,6 @@ void AddEnvironment ()
 				BrokenExceptionTransitions = environmentParser.BrokenExceptionTransitions,
 				PackageNamingPolicy = pnp,
 				BoundExceptionType = boundExceptionType,
-				InstantRunEnabled = InstantRunEnabled,
 				JniAddNativeMethodRegistrationAttributePresent = NativeCodeGenState.Template != null ? NativeCodeGenState.Template.JniAddNativeMethodRegistrationAttributePresent : false,
 				HaveRuntimeConfigBlob = haveRuntimeConfigBlob,
 				NumberOfAssembliesInApk = assemblyCount,

src/Xamarin.Android.Build.Tasks/Tasks/PrepareAbiItems.cs

@@ -31,9 +31,6 @@ public class PrepareAbiItems : AndroidTask
 		[Required]
 		public bool Debug { get; set; }
 
-		[Required]
-		public bool InstantRunEnabled { get; set; }
-
 		[Output]
 		public ITaskItem[] AssemblySources { get; set; }
 

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/GeneratePackageManagerJavaTests.cs

@@ -82,7 +82,6 @@ public void CheckPackageManagerAssemblyOrder (string[] resolvedUserAssemblies, s
 				SupportedAbis = new string [] { "x86" , "arm64-v8a" },
 				AndroidPackageName = "com.microsoft.net6.helloandroid",
 				EnablePreloadAssembliesDefault = false,
-				InstantRunEnabled = false,
 				Environments = new ITaskItem [] { new TaskItem (Path.Combine (path, "myenv.txt")) },
 			};
 			Assert.IsTrue (task.Execute (), "Task should have executed.");

src/Xamarin.Android.Build.Tasks/Utilities/ApplicationConfigNativeAssemblyGenerator.cs

@@ -173,7 +173,6 @@ sealed class XamarinAndroidBundledAssembly
 		public string AndroidPackageName { get; set; }
 		public bool BrokenExceptionTransitions { get; set; }
 		public global::Android.Runtime.BoundExceptionType BoundExceptionType { get; set; }
-		public bool InstantRunEnabled { get; set; }
 		public bool JniAddNativeMethodRegistrationAttributePresent { get; set; }
 		public bool HaveRuntimeConfigBlob { get; set; }
 		public bool HaveAssemblyStore { get; set; }
@@ -226,7 +225,7 @@ protected override void Construct (LlvmIrModule module)
 				aot_lazy_load = AotEnableLazyLoad,
 				uses_assembly_preload = UsesAssemblyPreload,
 				broken_exception_transitions = BrokenExceptionTransitions,
-				instant_run_enabled = InstantRunEnabled,
+				instant_run_enabled = false,
 				jni_add_native_method_registration_attribute_present = JniAddNativeMethodRegistrationAttributePresent,
 				have_runtime_config_blob = HaveRuntimeConfigBlob,
 				have_assemblies_blob = HaveAssemblyStore,

src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs

@@ -90,7 +90,6 @@ internal class ManifestDocument
 		public bool Debug { get; set; }
 		public bool MultiDex { get; set; }
 		public bool NeedsInternet { get; set; }
-		public bool InstantRunEnabled { get; set; }
 		public bool ForceExtractNativeLibs { get; set; }
 		public bool ForceDebuggable { get; set; }
 		public string VersionName { get; set; }

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

@@ -277,7 +277,6 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
 	<_AndroidSequencePointsMode Condition=" '$(MonoSymbolArchive)' == 'True' And '$(AndroidUseDebugRuntime)' == 'False' And '$(AotAssemblies)' == 'True' And '$(DebugSymbols)' == 'True' And ('$(DebugType)' == 'PdbOnly' Or '$(DebugType)' == 'Portable')">Offline</_AndroidSequencePointsMode>
 	<_AndroidSequencePointsMode Condition=" '$(MonoSymbolArchive)' == 'True' And '$(AndroidUseDebugRuntime)' == 'False' And '$(_AndroidSequencePointsMode)' == ''">Normal</_AndroidSequencePointsMode>
 	<_AndroidSequencePointsMode Condition=" '$(_AndroidSequencePointsMode)' == ''">None</_AndroidSequencePointsMode>
-	<_InstantRunEnabled Condition=" '$(_InstantRunEnabled)' == '' ">False</_InstantRunEnabled>
 	<_AndroidBuildPropertiesCache>$(IntermediateOutputPath)build.props</_AndroidBuildPropertiesCache>
 	<_AdbPropertiesCache>$(IntermediateOutputPath)adb.props</_AdbPropertiesCache>
 	<AndroidGenerateJniMarshalMethods Condition=" '$(AndroidGenerateJniMarshalMethods)' == '' ">False</AndroidGenerateJniMarshalMethods>
@@ -915,8 +914,7 @@ because xbuild doesn't support framework reference assemblies.
 		<_NuGetAssetsFile      Condition=" '$(_NuGetAssetsFile)' == '' and Exists('$(ProjectLockFile)') ">$(ProjectLockFile)</_NuGetAssetsFile>
 		<_NuGetAssetsFile      Condition=" '$(_NuGetAssetsFile)' == '' and Exists('packages.config') ">packages.config</_NuGetAssetsFile>
 		<_TypeMapKind Condition=" '$(AndroidIncludeDebugSymbols)' != 'True' ">mvid</_TypeMapKind>
-		<_TypeMapKind Condition=" '$(AndroidIncludeDebugSymbols)' == 'True' And '$(_InstantRunEnabled)' == 'True' ">strings-files</_TypeMapKind>
-		<_TypeMapKind Condition=" '$(AndroidIncludeDebugSymbols)' == 'True' And '$(_InstantRunEnabled)' != 'True' ">strings-asm</_TypeMapKind>
+		<_TypeMapKind Condition=" '$(AndroidIncludeDebugSymbols)' == 'True' ">strings-asm</_TypeMapKind>
 	</PropertyGroup>
 	<GetFileHash
 				Condition=" Exists('$(_NuGetAssetsFile)') "
@@ -1435,7 +1433,6 @@ because xbuild doesn't support framework reference assemblies.
   <PrepareAbiItems
       BuildTargetAbis="@(_BuildTargetAbis)"
       NativeSourcesDir="$(_NativeAssemblySourceDir)"
-      InstantRunEnabled="$(_InstantRunEnabled)"
       Debug="$(AndroidIncludeDebugSymbols)"
       Mode="typemap">
     <Output TaskParameter="AssemblySources" ItemName="_TypeMapAssemblySource" />
@@ -1464,6 +1461,7 @@ because xbuild doesn't support framework reference assemblies.
     <_LinkingEnabled Condition=" '$(AndroidLinkMode)' == 'None'">False</_LinkingEnabled>
     <_HaveMultipleRIDs Condition=" '$(RuntimeIdentifiers)' != '' ">True</_HaveMultipleRIDs>
     <_HaveMultipleRIDs Condition=" '$(RuntimeIdentifiers)' == '' ">False</_HaveMultipleRIDs>
+    <_AndroidGenerateNativeAssembly Condition=" '$(_AndroidGenerateNativeAssembly)' == '' ">True</_AndroidGenerateNativeAssembly>
   </PropertyGroup>
   <ItemGroup>
     <_MergedManifestDocuments Condition=" '$(AndroidManifestMerger)' == 'legacy' " Include="@(ExtractedManifestDocuments)" />
@@ -1478,7 +1476,6 @@ because xbuild doesn't support framework reference assemblies.
       Debug="$(AndroidIncludeDebugSymbols)"
       MultiDex="$(AndroidEnableMultiDex)"
       NeedsInternet="$(AndroidNeedsInternetPermission)"
-      InstantRunEnabled="$(_InstantRunEnabled)"
       AndroidSdkPlatform="$(_AndroidApiLevel)"
       AndroidSdkDir="$(_AndroidSdkDirectory)"
       PackageName="$(_AndroidPackage)"
@@ -1488,7 +1485,7 @@ because xbuild doesn't support framework reference assemblies.
       ManifestPlaceholders="$(AndroidManifestPlaceholders)"
       OutputDirectory="$(IntermediateOutputPath)android"
       TypemapOutputDirectory="$(_NativeAssemblySourceDir)"
-      GenerateNativeAssembly="!$(_InstantRunEnabled)"
+      GenerateNativeAssembly="$(_AndroidGenerateNativeAssembly)"
       MergedAndroidManifestOutput="$(_ManifestOutput)"
       EmbedAssemblies="$(EmbedAssembliesIntoApk)"
       BundledWearApplicationName="$(BundledWearApplicationPackageName)"
@@ -1505,13 +1502,8 @@ because xbuild doesn't support framework reference assemblies.
       HaveMultipleRIDs="$(_HaveMultipleRIDs)"
       IntermediateOutputDirectory="$(IntermediateOutputPath)"
       Environments="@(AndroidEnvironment);@(LibraryEnvironments)">
-    <Output TaskParameter="GeneratedBinaryTypeMaps" ItemName="_AndroidTypeMapping" Condition=" '$(_InstantRunEnabled)' == 'True' " />
   </GenerateJavaStubs>
 
-  <ItemGroup Condition=" '$(_InstantRunEnabled)' == 'True' and '@(_AndroidTypeMapping->Count())' == '0' ">
-    <_AndroidTypeMapping Include="$(_NativeAssemblySourceDir)typemaps\**\*" />
-  </ItemGroup>
-
   <ItemGroup>
     <FileWrites Include="@(_TypeMapAssemblySource)" />
     <FileWrites Include="@(_TypeMapAssemblyInclude)" />
@@ -1586,23 +1578,20 @@ because xbuild doesn't support framework reference assemblies.
   <PrepareAbiItems
     BuildTargetAbis="@(_BuildTargetAbis)"
     NativeSourcesDir="$(_NativeAssemblySourceDir)"
-    InstantRunEnabled="$(_InstantRunEnabled)"
     Debug="$(AndroidIncludeDebugSymbols)"
     Mode="environment">
       <Output TaskParameter="AssemblySources" ItemName="_EnvironmentAssemblySource" />
   </PrepareAbiItems>
   <PrepareAbiItems
     BuildTargetAbis="@(_BuildTargetAbis)"
     NativeSourcesDir="$(_NativeAssemblySourceDir)"
-    InstantRunEnabled="$(_InstantRunEnabled)"
     Debug="$(AndroidIncludeDebugSymbols)"
     Mode="compressed">
       <Output TaskParameter="AssemblySources" ItemName="_CompressedAssembliesAssemblySource" />
   </PrepareAbiItems>
   <PrepareAbiItems
     BuildTargetAbis="@(_BuildTargetAbis)"
     NativeSourcesDir="$(_NativeAssemblySourceDir)"
-    InstantRunEnabled="$(_InstantRunEnabled)"
     Debug="$(AndroidIncludeDebugSymbols)"
     Mode="marshal_methods">
       <Output TaskParameter="AssemblySources" ItemName="_MarshalMethodsAssemblySource" />
@@ -1631,7 +1620,6 @@ because xbuild doesn't support framework reference assemblies.
   <PrepareAbiItems
       BuildTargetAbis="@(_BuildTargetAbis)"
       NativeSourcesDir="$(_NativeAssemblySourceDir)"
-      InstantRunEnabled="$(_InstantRunEnabled)"
       Debug="$(AndroidIncludeDebugSymbols)"
       Mode="jniremap">
     <Output TaskParameter="AssemblySources" ItemName="_AndroidRemapAssemblySource" />
@@ -1729,7 +1717,6 @@ because xbuild doesn't support framework reference assemblies.
     EnablePreloadAssembliesDefault="$(_AndroidEnablePreloadAssembliesDefault)"
     PackageNamingPolicy="$(AndroidPackageNamingPolicy)"
     BoundExceptionType="$(AndroidBoundExceptionType)"
-    InstantRunEnabled="$(_InstantRunEnabled)"
     RuntimeConfigBinFilePath="$(_BinaryRuntimeConfigPath)"
     UseAssemblyStore="$(AndroidUseAssemblyStore)"
     EnableMarshalMethods="$(_AndroidUseMarshalMethods)"

src/Xamarin.Android.Build.Tasks/Xamarin.Android.D8.targets

@@ -64,7 +64,7 @@ Copyright (C) 2018 Xamarin. All rights reserved.
         Debug="$(AndroidIncludeDebugSymbols)"
         JavaPlatformJarPath="$(JavaPlatformJarPath)"
         ClassesZip="$(_AndroidIntermediateClassesZip)"
-        JavaLibrariesToEmbed="@(_JavaLibrariesToCompileForApp);@(_InstantRunJavaReference)"
+        JavaLibrariesToEmbed="@(_JavaLibrariesToCompileForApp);"
         JavaLibrariesToReference="@(AndroidExternalJavaLibrary)"
         EnableDesugar="$(AndroidEnableDesugar)"
         AndroidSdkBuildToolsPath="$(AndroidSdkBuildToolsPath)"
@@ -95,7 +95,7 @@ Copyright (C) 2018 Xamarin. All rights reserved.
         Debug="$(AndroidIncludeDebugSymbols)"
         JavaPlatformJarPath="$(JavaPlatformJarPath)"
         ClassesZip="$(_AndroidIntermediateClassesZip)"
-        JavaLibrariesToEmbed="@(_JavaLibrariesToCompileForApp);@(_InstantRunJavaReference)"
+        JavaLibrariesToEmbed="@(_JavaLibrariesToCompileForApp)"
         AlternativeJarLibrariesToEmbed="@(_AlternativeJarForAppD8)"
         JavaLibrariesToReference="@(AndroidExternalJavaLibrary)"
         EnableDesugar="$(AndroidEnableDesugar)"