-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MXE build of libzip #868
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dotnet@fa9f62a failed to update the MXE build of the library and so it was still being built as a static archive (which is the new libzip default) and caused build failures when building libzip executables. This commit makes MXE build a shared version of the library and, hopefully, fixes the issue.
What's weird is that this fails after 3h50min: |
In the meantime, I'm reverting PR #863 so that we get get master green again, and resume merging PRs. |
New PR opened which combines both *nix and Windows changes (and hopefully fixes the build): #874 |
jonpryor
pushed a commit
that referenced
this pull request
Sep 8, 2021
Fixes: dotnet/java-interop#863 Changes: dotnet/java-interop@b7982e4...f359e73 * dotnet/java-interop@f359e731: [generator] Generate more [SupportedOSPlatform] attributes (#868)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
full-mono-integration-build
For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fa9f62a failed to update the MXE build of the library
and so it was still being built as a static archive (which is the
new libzip default) and caused build failures when building
libzip executables.
This commit makes MXE build a shared version of the library and,
hopefully, fixes the issue.