Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] remove darc dependency for System.IO.Hashing #7855

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

jonathanpeppers
Copy link
Member

Maestro is currently failing to open new PRs due to:

> darc update-dependencies --id 169161
Looking up build with BAR id 169161
Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23128.1' => '8.0.100-preview.3.23153.7' (from build '20230303.7' of 'https://github.com/dotnet/installer')
Checking for coherency updates...
Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made.
Coherency updates failed for the following dependencies:
Unable to update System.IO.Hashing to have coherency with Microsoft.Dotnet.Sdk.Internal: https://github.com/dotnet/installer @ 9cf0095d0892d385a7e26772752d75e3bb68d8e4 does not contain dependency System.IO.Hashing

In 5d68699, we added a new dependency of System.IO.Hashing from dotnet/runtime.

But for this to work, we'd have to:

  1. List System.IO.Hashing as a dependency of dotnet/installer

or

  1. Just use manage $(SystemIOHashingPackageVersion) to match the overall version of dotnet/runtime.

In dotnet/maui, at lot of times they've been going with no. 2. If needed on release branches, we can also hardcode the number or switch over to using a stable version on NuGet.org.

Let's remove the Maestro dependency and use $(MicrosoftNETCoreAppRefPackageVersion) for now.

Maestro is currently failing to open new PRs due to:

    > darc update-dependencies --id 169161
    Looking up build with BAR id 169161
    Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23128.1' => '8.0.100-preview.3.23153.7' (from build '20230303.7' of 'https://github.com/dotnet/installer')
    Checking for coherency updates...
    Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made.
    Coherency updates failed for the following dependencies:
    Unable to update System.IO.Hashing to have coherency with Microsoft.Dotnet.Sdk.Internal: https://github.com/dotnet/installer @ 9cf0095d0892d385a7e26772752d75e3bb68d8e4 does not contain dependency System.IO.Hashing

In 5d68699, we added a new dependency of System.IO.Hashing from
dotnet/runtime.

But for this to work, we'd have to:

1. List `System.IO.Hashing` as a dependency of dotnet/installer

or

2. Just use manage `$(SystemIOHashingPackageVersion)` to match the
   overall version of dotnet/runtime.

In dotnet/maui, at lot of times they've been going with no. 2. If
needed on release branches, we can also hardcode the number or switch
over to using a stable version on NuGet.org.

Let's remove the Maestro dependency and use
`$(MicrosoftNETCoreAppRefPackageVersion)` for now.
@jonathanpeppers
Copy link
Member Author

The one failure is happening in some other PRs, so I think we can merge:

     (CoreCompile target) -> 
         /Users/runner/work/1/s/xamarin-android/tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs(42,4): error CS0246: The type or namespace name 'RetryAttribute' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/work/1/s/xamarin-android/tests/Mono.Android-Tests/Runtime-Microsoft.Android.Sdk/Mono.Android.NET-Tests.csproj]
         /Users/runner/work/1/s/xamarin-android/tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs(42,4): error CS0246: The type or namespace name 'Retry' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/work/1/s/xamarin-android/tests/Mono.Android-Tests/Runtime-Microsoft.Android.Sdk/Mono.Android.NET-Tests.csproj]

    366 Warning(s)
    2 Error(s)

@jonathanpeppers jonathanpeppers merged commit 92eca7c into dotnet:main Mar 6, 2023
@jonathanpeppers jonathanpeppers deleted the System.IO.Hashing branch March 6, 2023 18:25
grendello added a commit to grendello/xamarin-android that referenced this pull request Mar 7, 2023
* main:
  Bump r8 from 4.0.48 to 4.0.52 (dotnet#7858)
  [tests] Fix recently added AndroidMessageHandler test (dotnet#7859)
  [build] remove darc dependency for System.IO.Hashing (dotnet#7855)
  Localized file check-in by OneLocBuild Task (dotnet#7851)
grendello added a commit to grendello/xamarin-android that referenced this pull request Mar 9, 2023
* main:
  [ci] Don't run classic tests on the Windows build/test stage (dotnet#7860)
  Bump to xamarin/Java.Interop/main@73ebad2 (dotnet#7861)
  Bump r8 from 4.0.48 to 4.0.52 (dotnet#7858)
  [tests] Fix recently added AndroidMessageHandler test (dotnet#7859)
  [build] remove darc dependency for System.IO.Hashing (dotnet#7855)
  Localized file check-in by OneLocBuild Task (dotnet#7851)
grendello added a commit to grendello/xamarin-android that referenced this pull request Mar 9, 2023
* main:
  [ci] Don't run classic tests on the Windows build/test stage (dotnet#7860)
  Bump to xamarin/Java.Interop/main@73ebad2 (dotnet#7861)
  Bump r8 from 4.0.48 to 4.0.52 (dotnet#7858)
  [tests] Fix recently added AndroidMessageHandler test (dotnet#7859)
  [build] remove darc dependency for System.IO.Hashing (dotnet#7855)
  Localized file check-in by OneLocBuild Task (dotnet#7851)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants