[One .NET] fix libmono-profiler-aot.so recording #6680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when I went to update the AOT profile in .NET MAUI:
https://github.com/jonathanpeppers/android-profiled-aot
dotnet/maui#4355
The profiler crashed with:
But the directory was writeable?
After some digging, it turned out appending
,
to this line fixed theissue:
https://github.com/xamarin/xamarin-android/blob/b7a368a27667c69117f64be81050403f2d5c8560/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Application.targets#L45
What happened was we lost a
,
somewhere in this commit:f73a323
To fix this:
Prepend a
,
I found a way to actually enable tests for Profiled AOT in .NET 6
by downloading binaries from my Github repo.
In enabling the
ProfiledAOT
category for .NET 6, I found that thissetting wasn't working:
I updated
%(_MonoAOTAssemblies.ProcessArguments)
to solve this.