[tests] raise acceptable timings for performance tests #4531
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#4487 7117414 raised the acceptable build times for three tests: * `Build_From_Clean_DontIncludeRestore` * `Build_AndroidManifest_Change` * `Build_JLO_Change` Unfortunately, we didn't increase the times enough. I raised them a bit more, so they should pass more reliably. In a future PR, we could consider using the ABI of the connected emulator/device to only build & generate an APK for that specific device. I could see this improving the regressed timings here, as the `_GenerateJavaStubs` and native assembly compilation are taking additional time per-ABI.
jonpryor
pushed a commit
that referenced
this pull request
Apr 7, 2020
Context: https://build.azdo.io/3616517 Context: #4487 Commit 7117414 raised the acceptable build times for three tests: * `Build_AndroidManifest_Change` * `Build_JLO_Change` Unfortunately, we didn't increase the times enough. I raised them a bit more, so they should pass more reliably. In a future PR, we could consider using the ABI of the connected emulator/device to only build & generate an APK for that specific device. I could see this improving the regressed timings here, as the `_GenerateJavaStubs` and native assembly compilation are taking additional time per-ABI.
jonpryor
pushed a commit
that referenced
this pull request
Apr 8, 2020
Context: https://build.azdo.io/3616517 Context: #4487 Commit 7117414 raised the acceptable build times for three tests: * `Build_From_Clean_DontIncludeRestore` * `Build_AndroidManifest_Change` * `Build_JLO_Change` Unfortunately, we didn't increase the times enough. I raised them a bit more, so they should pass more reliably. In a future PR, we could consider using the ABI of the connected emulator/device to only build & generate an APK for that specific device. I could see this improving the regressed timings here, as the `_GenerateJavaStubs` and native assembly compilation are taking additional time per-ABI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://build.azdo.io/3616517
Context: #4487
7117414 raised the acceptable build times for three tests:
Build_From_Clean_DontIncludeRestoreBuild_AndroidManifest_ChangeBuild_JLO_ChangeUnfortunately, we didn't increase the times enough. I raised them a
bit more, so they should pass more reliably.
In a future PR, we could consider using the ABI of the connected
emulator/device to only build & generate an APK for that specific
device. I could see this improving the regressed timings here, as the
_GenerateJavaStubsand native assembly compilation are takingadditional time per-ABI.