[aot] Make it possible to use AOT compiler without NDK #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekdoulik
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
grendello
approved these changes
Jul 2, 2019
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets
Outdated
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Jul 2, 2019
dellis1972
requested changes
Jul 3, 2019
We redistributed as, ld and strip tools and point AOT compiler to them. For AOT/llvm we still depend on NDK.
Co-Authored-By: Jonathan Peppers <[email protected]>
radekdoulik
force-pushed
the
pr-aot-without-ndk-2
branch
from
e32ce7b to
db50255
Compare
This test checks the error messages about NDK, but normal AOT should not fail anymore, because it doesn't need NDK. So update it to try AOT/LLVM instead, which still requires NDK.
|
@monojenkins build failed |
|
build "Xamarin.Android" |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
you mean without LLVM? what is the difference between NDK and ndk-bundle? isnt ndk bundle a copy of ndk? i have been using aot+llvm with ndk-bundle all the time without any issue. |
|
@monojenkins build failed |
jonpryor
pushed a commit
that referenced
this pull request
Aug 9, 2019
…3317) Fixes: #3299 Profiled AOT (6e88ffa) requires a handful of things to work: 1. The mono cross-compilers, and 2. Various Android NDK tools such as `as` (assembler), `ld` (linker), and `strip`. As of decfbcc, Xamarin.Android *already* redistributes `as`. Update `make prepare` and installer creation so that Xamarin.AndroidAotMode also redistributes `ld` and `strip` for all supported ABIs. This has two benefits: 1. Profiled AOT and "normal" AOT use will not require that the full Android NDK be installed. 2. Redistribution helps "firewall" the binaries for macOS Catalina. The full Android NDK is a ~700-800MB download (r19c is 770MB, r20 is 804MB) and ~3GB extracted/installed, while adding `ld` and `strip` to our installation only increases the `.pkg` size by ~8MB and installation size by ~20MB. (`as` is already installed.) Redistribution of `ld` and `strip` thus makes it much easier for customers to use AOT. **Note**: AOT+LLVM (`$(AndroidAotMode)` != None *and* `$(EnableLLVM)`=True) still requires a full NDK. Finally, macOS Catalina is [removing support for 32-bit apps][0]. The Android NDK r8d and earlier provide 32-bit binaries for some (all?) of these utilities, and thus they won't work on the forthcoming macOS 10.15 Catalina release. The [NDK r8e][1] release notes state: > Added 64-bit host toolchain set (package name suffix *-x86_64.*). > For more information, see `CHANGES.HTML` and `NDK-BUILD.html`. Including these utilities thus removes a partial dependency on the installed Android NDK, which should increase the likelihood of successful Profiled AOT use on macOS Catalina. [0]: https://support.apple.com/en-us/HT208436 [1]: https://developer.android.com/ndk/downloads/revision_history
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3299
We will redistribute
as,ldandstriptools and point AOT compiler tothese.
For AOT/llvm we still depend on NDK.