Color binding changes #1225
Merged
Color binding changes #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abling color metadata fixup. Things are not as simple and stupid as you dream without working on it...
…WallpaperColor. It turned out that the criminal who generated _Color and ColorObject as internal was *metadata fixup*, not generator itself. It was buried in thousands of lines of `src/Mono.Android/metadata`. Color is absolutely a technical debt that Xamarin.Android should clean up and provide every related API in int properties and constants, but so far add a workaround by renamed Color->ColorObject class.
|
For internal reference: original Color design was added back in 2012 at monodroid/e47da17f |
|
regarding #1201 here is the results from Type Changed: Android.App.WallpaperManagerAdded methods: public virtual void AddOnColorsChangedListener (WallpaperManager.IOnColorsChangedListener, Android.OS.Handler); public virtual WallpaperColors GetWallpaperColors (int); public virtual void RemoveOnColorsChangedListener (WallpaperManager.IOnColorsChangedListener); |
jonpryor
reviewed
Jan 24, 2018
| @@ -1390,16 +1387,10 @@ | |||
|
|
|||
| We will have to enable this line and bring back some sanity. | |||
| --> | |||
| <!-- attr path="/api/package[@name='android.graphics']/class[@name='Color']" name="managedName">AndroidColor</attr --> | |||
| <attr path="/api/package[@name='android.graphics']/class[@name='Color']" name="managedName">ColorObject</attr> | |||
There was a problem hiding this comment.
Why ColorObject and not AndroidColor?
There was a problem hiding this comment.
I am 100% sure that people try to look up "Color" something. AndroidColor will never give that impression to developers.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 31, 2021
jonpryor
added a commit
that referenced
this pull request
Aug 31, 2021
Context: #5749 Changes: xamarin/monodroid@5676b84...0156d4e * xamarin/monodroid@0156d4e51: Bump to xamarin/androidtools@ae1f8fbe (#1225) * xamarin/monodroid@33a26e453: Bump to xamarin/android-sdk-installer@98fa41ba (#1224)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see how generator is messing around by simply enabling color metadata fixup. Things are not as simple and stupid as you dream without working on it...