Add SslOverTdsStream tests #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Show resolved
Hide resolved
cheenamalhotra
added
the
Area\Tests
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
|
/me pokes @cheenamalhotra |
|
The PR is currently in review with team @Wraith2. We are hoping to get this merged soon! 😊 |
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Show resolved
Hide resolved
JRahnama
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SslOverTdsStreamTest.cs
Outdated
Show resolved
Hide resolved
JRahnama
approved these changes
Apr 23, 2020
cheenamalhotra
approved these changes
Apr 23, 2020
karinazhou
approved these changes
Apr 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to change the internal class
SslOverTdsStreamto remove sync-over-async and remove some allocations. To do that I need to add tests to prevent adding of new bugs.These use each pair of
ReadandWriteoverloads onStreamto write a known pattern of 4 encapsulated and 4 unencapsulated packets to a memory stream and then read them back and verify the data is the same. Reflection is used to find, instantiate and callFinishHandshakeon the stream. I chose to do this rather than include the source files because it's easier in this case where there are only two methods required and it doesn't introduce a code share between dev and test.