Add encalve enabled always encrypted feature #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
karinazhou
commented
Oct 30, 2019
karinazhou
commented
- Add enclave providers for Azure Attestation Service and Host Guardian Service.
- Support always encrypted for secure enclave attestation in .NET Framework and .NET Core (Not supported on .NET Standard for now)
- Improve some AE tests for enclave support.
# Conflicts: # src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsEnums.cs # src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.resx
…into AE-with-enclave # Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
…into AE-with-enclave-kz # Conflicts resolved
…ences from netCore
…into AE-with-enclave # Conflicts resolved # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AlwaysEncryptedAttestationException.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AlwaysEncryptedEnclaveProviderUtils.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/EnclaveProviderBase.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProviderBase.NetCoreApp.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedAttestationException.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AzureAttestationBasedEnclaveProvider.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/EnclaveProviderBase.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProvider.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProviderBase.cs
* make attestation stuff internal * Add AE enclave support in .NET Core * Fix error message and add dependencies
Reverting auto format change on last revert One other minor edit
…into AE-with-enclave
…into AE-with-enclave
David-Engel
reviewed
Nov 1, 2019
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/EnclaveDelegate.cs
Outdated
Show resolved
Hide resolved
…into AE-with-enclave
…into AE-with-enclave
yukiwongky
approved these changes
Nov 4, 2019
JRahnama
approved these changes
Nov 4, 2019
David-Engel
requested changes
Nov 4, 2019
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
David-Engel
approved these changes
Nov 4, 2019
* Get and set expected value for DdType.Date and DbType.Time Breaks support for SQL Server 2008 (I believe) fixes #5 Extend DateTimeTest.ReaderParameterTest to cover DbType parameters
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.