Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting readonly column metadata #286

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix getting readonly column metadata #286

merged 2 commits into from
Oct 25, 2019

Conversation

yukiwongky
Copy link
Contributor

Fixes #275

@yukiwongky yukiwongky mentioned this pull request Oct 25, 2019
Closed
@Wraith2
Copy link
Contributor

Wraith2 commented Oct 25, 2019

LGTM

@David-Engel David-Engel added this to the 1.1.0 milestone Oct 25, 2019
@David-Engel David-Engel merged commit 486908b into dotnet:master Oct 25, 2019
@yukiwongky yukiwongky mentioned this pull request Oct 25, 2019
Merged
@yukiwongky
Copy link
Contributor Author

Ported to corefx in PR#42122

@David-Engel David-Engel modified the milestones: 1.1.0, 1.1.0-preview2 Nov 4, 2019
yukiwongky added a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@yukiwongky @David-Engel
Fix getting readonly column metadata (dotnet#286)
9800bbe
yukiwongky added a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@yukiwongky @David-Engel
Fix getting readonly column metadata (dotnet#286)
a3b69be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh500 saurabh500 saurabh500 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-preview2
Development

Successfully merging this pull request may close these issues.

SQLDataAdapter.FillSchema doesn't mark computed columns as readonly
4 participants
@yukiwongky @Wraith2 @saurabh500 @David-Engel