Add XML documentation for publishing library to .Net API Reference #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.proj
* add more code samples from api reference * add documentation xml files * add include tags for SqlConnectionColumnEncryptionSetting.xml and SqlConnectionStringBuilder.xml * add include tags for SqlCredential.xml * add include tags for SqlDataAdapter.xml * add includes for SqlDataReader.xml * add include tags for SqlDependency.xml * add include tags for SqlEnclaveAttestationParameters.xml * add include tags for SqlEnclaveSession.xml * add include tags for SqlError.xml * add include tags for SqlErrorCollection.xml and SqlException.xml * add include tags for SqlInfoMessageEventArgs.xml and SqlInfoMessageEventHandler.xml * add inclue tags for SqlNotification xmls * add newline at the end of each xml file * add include tags for SqlParameter and SqlParameterCollection.xml * add more include tags * change snippet tag location to before using MDS * add SqlConnection documentation * replace using SDS with MDS in samples
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.Manual.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
reviewed
Sep 27, 2019
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
yukiwongky
approved these changes
Sep 27, 2019
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs
cheenamalhotra
added
the
📍 Push to Commit Feed
Closed
|
NuGet Package from Commits Feed: |
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
…ence (dotnet#210) Contributors: @JRahnama @v-kaywon @cheenamalhotra Changes with this PR: - Adds common XML doc snippets to be extracted for XML documentation - Adds Samples to repository included in documentation - Updated both NetFx and NetCore drivers with documentation includes. - GitIgnore update to exclude `nuget.exe` - build.proj now defaults to `BuildAllConfigurations` target. Addresses dotnet#197 - Added include tags in 'ref' classes for Visual Studio Intellisense support. Additional Changes in this PR: - `Microsoft.Data.SqlTypes.SqlFileStream` added in NetFx. - Existing tests run against the newly added SqlFileStream class. As of now, this PR brings documentation over from System.Data.SqlClient. Work to be continued to enhance missing docs in future PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of hardwork coming in!
Contributors:
@JRahnama @v-kaywon @cheenamalhotra
Changes with this PR:
nuget.exeBuildAllConfigurationstarget. Addresses Release Nuget package generation #197Additional Changes in this PR:
Microsoft.Data.SqlTypes.SqlFileStreamadded in NetFx.As of now, this PR brings documentation over from System.Data.SqlClient.
Work to be continued to enhance missing docs in future PRs.