Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes 5.0.2 #1979

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Release notes 5.0.2 #1979

merged 3 commits into from
Mar 31, 2023

Conversation

lcheunglci
Copy link
Contributor

Add release notes for 5.0.2 Hotfix release.

@lcheunglci lcheunglci added the Area\Documentation Issue that requires changes in public documentations/samples. label Mar 30, 2023
@lcheunglci lcheunglci added this to the 5.0.2 milestone Mar 30, 2023
@lcheunglci lcheunglci marked this pull request as ready for review March 31, 2023 03:12
@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 31, 2023

Is this not in 5.0.2 ?? #1810

@roji
Copy link
Member

roji commented Mar 31, 2023

Yeah, to second @ErikEJ, #1810 (memory leak because of cancellation token) is quite serious, and it would be good to see a backport of the fix to 5.0.x. FYI the EF SQL Server 7.0 provider depends on 5.0.1, and we generally don't bump minor/major versions of dependencies in our own patch versions. In other words, while EF Core 8.0 may depend on 5.1.x (where the bug is already fixed), current users of EF 7 will still have this issue.

/cc @ajcvickers

@lcheunglci
Copy link
Contributor Author

lcheunglci commented Mar 31, 2023

Thanks @ErikEJ and @roji for pointing that out the dependency from EF Server 7, and looks like we backported #1785, which resulted in that regression in v5.0.1, and I've created backport PR #1980 with the changes from #1810 and I've CC'ed @David-Engel to confirm and will also need to backport #1906 nevermind this one was a regression from #1692 which was not ported over .

@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 31, 2023

@lcheunglci Thanks a lot!

@lcheunglci lcheunglci merged commit a9c2dba into dotnet:main Mar 31, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Documentation Issue that requires changes in public documentations/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants