-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | Dropping reference to Microsoft.Win32.Registry in netcore. #1974
Conversation
…age is shipped with net6.
What does this fix? |
Warnings on build time and also on Visual studio in referenced packages. |
@JRahnama |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
+ Coverage 70.48% 70.51% +0.03%
==========================================
Files 306 306
Lines 61661 61661
==========================================
+ Hits 43460 43482 +22
+ Misses 18201 18179 -22
Flags with carried forward coverage won't be shown. Click here to find out more. see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I did check the test. With modifying Update: The change for the hostname was unnecessary and it worked fine with setting Encrypt = false only. I will look into setting up the pipelines to be able to handle that test. |
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/ConnectivityTest.cs
Show resolved
Hide resolved
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
According to this announcement Microsoft.Win32.Registry is shipped with net 6 and after versions. Removing the reference in netcore csproj will eliminate the warning.