Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Shared -SqlDataRecord #1309

Merged
merged 10 commits into from
Oct 13, 2021
Merged

Move to Shared -SqlDataRecord #1309

merged 10 commits into from
Oct 13, 2021

Conversation

Kaur-Parminder
Copy link
Contributor

This is part of #1261 issue code merge classes. Moved the SqlDataRecord common code to .Common.cs class and insternally invoked private methods from corresponsding FrameworkSpecific methods.

@Kaur-Parminder
Move to Shared -SqlDataRecord
b8f3ebc 
this is part of dotnet#1261 issue code merge classes. Moved the SqlDataRecord common code to .Common.cs class and insternally invoked private methods from corresponsding FrameworkSpecific methods.
@dnfadmin
Copy link

dnfadmin commented Oct 4, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@Kaur-Parminder Kaur-Parminder mentioned this pull request Oct 4, 2021
Open
@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Oct 4, 2021
@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Oct 4, 2021
DavoudEshtehari
DavoudEshtehari reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! just some minor improvements; remove unused namespaces and extra blank lines.

@Kaur-Parminder
Adressing review comment
de5159b 
Removed blankspaces, unused namespaces.
@Kaur-Parminder
Addressing Review comments
c6714e8 
Removing extra spaces and unused namespaces
@Kaur-Parminder
Review comments
b0b60f0 
Identatation and split into two lines for long lines
@Kaur-Parminder
Copy link
Contributor Author

Good job! just some minor improvements; remove unused namespaces and extra blank lines.

@DavoudEshtehari Thanks Davoud, I have made the changes.

@johnnypham
Copy link
Contributor

Nit: some members in the common file can be changed to expression-bodied members.

@Kaur-Parminder
Addressing reviewer's comment
8204fc1 
updated methods to use Expression bodied members
@Kaur-Parminder
Copy link
Contributor Author

Nit: some members in the common file can be changed to expression-bodied members.

Thanks Johnny, I updated wherever VS suggested.

@DavoudEshtehari DavoudEshtehari merged commit 7305c1c into dotnet:main Oct 13, 2021
@Kaur-Parminder Kaur-Parminder deleted the Move-to-Shared-location-SqlDataRecord branch January 12, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnypham johnnypham johnnypham approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Assignees
No one assigned
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaur-Parminder @dnfadmin @johnnypham @DavoudEshtehari