Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak event counter display info #1091

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Tweak event counter display info #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ...ft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientEventSource.NetCoreApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,61 +67,61 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
_activeHardConnections = _activeHardConnections ??
new PollingCounter("active-hard-connections", this, () => _activeHardConnectionsCounter)
{
DisplayName = "Actual active connections are made to servers",
DisplayName = "Actual active connections currently made to servers",
DisplayUnits = "count"
};

_hardConnectsPerSecond = _hardConnectsPerSecond ??
new IncrementingPollingCounter("hard-connects", this, () => _hardConnectsCounter)
{
DisplayName = "Actual connections are made to servers",
DisplayName = "Actual connection rate to servers",
DisplayUnits = "count / sec",
DisplayRateTimeScale = TimeSpan.FromSeconds(1)
};

_hardDisconnectsPerSecond = _hardDisconnectsPerSecond ??
new IncrementingPollingCounter("hard-disconnects", this, () => _hardDisconnectsCounter)
{
DisplayName = "Actual disconnections are made to servers",
DisplayName = "Actual disconnection rate from servers",
DisplayUnits = "count / sec",
DisplayRateTimeScale = TimeSpan.FromSeconds(1)
};

_activeSoftConnections = _activeSoftConnections ??
new PollingCounter("active-soft-connects", this, () => _activeSoftConnectionsCounter)
{
DisplayName = "Active connections got from connection pool",
DisplayName = "Active connections retrieved from the connection pool",
DisplayUnits = "count"
};

_softConnects = _softConnects ??
new IncrementingPollingCounter("soft-connects", this, () => _softConnectsCounter)
{
DisplayName = "Connections got from connection pool",
DisplayName = "Rate of connections retrieved from the connection pool",
DisplayUnits = "count / sec",
DisplayRateTimeScale = TimeSpan.FromSeconds(1)
};

_softDisconnects = _softDisconnects ??
new IncrementingPollingCounter("soft-disconnects", this, () => _softDisconnectsCounter)
{
DisplayName = "Connections returned to the connection pool",
DisplayName = "Rate of connections returned to the connection pool",
DisplayUnits = "count / sec",
DisplayRateTimeScale = TimeSpan.FromSeconds(1)
};

_numberOfNonPooledConnections = _numberOfNonPooledConnections ??
new PollingCounter("number-of-non-pooled-connections", this, () => _nonPooledConnectionsCounter)
{
DisplayName = "Number of connections are not using connection pooling",
DisplayUnits = "count / sec"
DisplayName = "Number of connections not using connection pooling",
DisplayUnits = "count"
};

_numberOfPooledConnections = _numberOfPooledConnections ??
new PollingCounter("number-of-pooled-connections", this, () => _pooledConnectionsCounter)
{
DisplayName = "Number of connections are managed by connection pooler",
DisplayUnits = "count / sec"
DisplayName = "Number of connections managed by the connection pool",
DisplayUnits = "count"
};

_numberOfActiveConnectionPoolGroups = _numberOfActiveConnectionPoolGroups ??
Expand Down Expand Up @@ -162,7 +162,7 @@ protected override void EventCommandMethodCall(EventCommandEventArgs command)
_numberOfFreeConnections = _numberOfFreeConnections ??
new PollingCounter("number-of-free-connections", this, () => _freeConnectionsCounter)
{
DisplayName = "Number of free-ready connections",
DisplayName = "Number of ready connections in the connection pool",
DisplayUnits = "count"
};

Expand Down Expand Up @@ -241,7 +241,7 @@ internal override void ExitNonPooledConnection()
}

/// <summary>
/// The number of connections that are managed by the connection pooler
/// The number of connections that are managed by the connection pool
/// </summary>
[NonEvent]
internal override void EnterPooledConnection()
Expand All @@ -250,7 +250,7 @@ internal override void EnterPooledConnection()
}

/// <summary>
/// The number of connections that are managed by the connection pooler
/// The number of connections that are managed by the connection pool
/// </summary>
[NonEvent]
internal override void ExitPooledConnection()
Expand Down