PropertyGrid and SQLConnectionStringBuilder

[FJGR65]

When I try to edit the properties of the SqlConnectionStringBuilder in a PropertyGrid there is a problem with the synonyms. Properties appear with their original names and synonyms.
Categories don't work either, as do descriptions.

The application is on .NET 5.0

[Wraith2]

Runtime or design time? The ref assembly looks like it's correctly annotated with ComponentModel attributes so it should behave properly at design time. The implementation in the src assembly doesn't have the attributes though, so if this is runtime then we can fix it, if it's design time then I'm not sure what's happening.

[FJGR65]

It's at runtime.

Thank you for the correction.

[Wraith2]

It should be pretty simple to fix then. We just need to annotate the src with the same attributes as ref.

[JRahnama]

@FJGR65 Thanks for bringing up this issue to our attention. We will look into it shortly.
@Wraith2 Thank you for the solution.

[JRahnama]

@FJGR65 I added the annotations to src, but when it comes to testing I had some difficulties creating the grid. Can you walk me through the steps you have taken to make the property grid in netcore please?

[FJGR65]

Sorry. I'm in holidays. Tomorrow send te code. El lun., 5 jul. 2021 19:20, Javad ***@***.***> escribió:

…

@FJGR65 <https://github.com/FJGR65> I added the annotations to src, but when it comes to testing I had some difficulties creating the grid. Can you walk me through the steps you have taken to make the property grid in netcore please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARNNLELK5MURMA3QCZFDTQTTWHSWXANCNFSM47MHAJMA> .

[FJGR65]

Good Morning:

I do not know how to upload a project to the comments, so I send you the code by e-mail. It is a reduced version of what I am doing, but I hope it is useful to test your annotations.

[JRahnama]

Good Morning:

I do not know how to upload a project to the comments, so I send you the code by e-mail. It is a reduced version of what I am doing, but I hope it is useful to test your annotations.

Thank you. I got the code. I will start testing the fixes and will update you shortly.

[FJGR65]

Thanks. I'm at the beach, but if you need anything else, I can send it to you tomorrow. El mar., 6 jul. 2021 18:32, Javad ***@***.***> escribió:

…

Good Morning: I do not know how to upload a project to the comments, so I send you the code by e-mail. It is a reduced version of what I am doing, but I hope it is useful to test your annotations. Thank you. I got the code. I will start testing the fixes and will update you shortly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARNNLEOPZG54A4BIR7AXAK3TWMVZVANCNFSM47MHAJMA> .

[JRahnama]

@FJGR65 I tested and everything is working as expected. Please check the fixe in your convenient time and confirm that the issue is solved.

Thanks for bringing up the issue.
Regards

[FJGR65]

Thank you very much for the solution. There are no problems with the synonyms, although the categories and descriptions continue without appearing. However, for me it is enough.

[ErikEJ]

@FJGR65 Can you share a screenshot that demonstrates the missing parts?

[FJGR65]

This is with new fixes:

This is with .Net Framework 4.5.2 with System.Data.SqlClient (in spanish, sorry)

[Wraith2]

Missing CategoryAttribute annotations.

[FJGR65]

And descriptions not show. El mié., 7 jul. 2021 15:40, Wraith ***@***.***> escribió:

…

Missing CategoryAttribute annotations. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARNNLEOQJQ5Y7OFUST4QJXTTWRKNXANCNFSM47MHAJMA> .

[Wraith2]

We have localized versions of CategoryAttribute and DescriptionAttribute called ResCategoryAttribute and ResDescriptionAttribute which allow localization, those will need to be applied.

[cheenamalhotra]

CategoryAttributes could be applied to match the behavior with .NET Framework, but we don't have localized resources supported in .NET Core yet.

That would be part of a separate task, just FYI. cc @David-Engel
If it can work in English, it should be acceptable fix for this particular issue.

[Wraith2]

I think english would be better than nothing, at least there's an indication of category in that case even if the category itself isn't in the right language.

[JRahnama]

That would be part of a separate task, just FYI. cc @David-Engel David Engel (Simba Technologies Inc) Vendor
If it can work in English, it should be acceptable fix for this particular issue.

David approved that English-only is better than nothing.

There are several changes made to the PR. More file has changed.

@FJGR65 can you check with the new build from the PR?

[FJGR65]

First, thank all of you for the effort made to solve the problem. The result has been much more than satisfactory, since my intention was simply to solve the problem with the PropertyGrid.
You have managed to work properly, to show the categories and descriptions. It is much more than expected. Thank you.

As for the issue of translations, I just hoped they were in English. The screen shown in Spanish was because I am on holidays and it is very difficult for me to access my development computer on remote, so I could not show the screen in English. It has also been rather complicated to respond more quickly to your requirements, since I do not have access to the Internet on the beach and I have had to move to perform the tests and screenshots.

Anyway, it has been very rewarding to check the quick response from you, kindness and willingness to solve the problem. Thanks.

Finally, I show you the last screenshot in which it is checked that the PropertyGrid works correctly. Thus, for me, the problem is completely solved.

All the best
Francisco

[ErikEJ]

So Categories work on an English system?

[FJGR65]

Is working in a spanish system perfectly. For me its ok. El jue., 8 jul. 2021 12:21, Erik Ejlskov Jensen ***@***.***> escribió:

…

So Categories work on an English system? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARNNLELPPCSM2MTTLQ2M2GTTWV34HANCNFSM47MHAJMA> .

[JRahnama]

So Categories work on an English system?

Descriptions are English-only for now.

[Wraith2]

but we don't have localized resources supported in .NET Core yet.

If there isn't an issue to track localization in netcore can we open one? The localized resources are in netfx so in theory it's all just waiting on the source merges.