address feedback

dotnet · Jun 11, 2021 · b8e8c13 · b8e8c13
1 parent 18af93b
commit b8e8c13
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlParameter.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlParameter.cs
@@ -733,7 +733,7 @@ public override object Value
                 _coercedValue = null;
                 _valueAsINullable = _value as INullable;
                 SetFlag(SqlParameterFlags.IsSqlParameterSqlType, _valueAsINullable != null);
-                SetFlag(SqlParameterFlags.IsNull, (null == _value) || (_value == DBNull.Value) || HasFlag(SqlParameterFlags.IsSqlParameterSqlType) && _valueAsINullable.IsNull);
+                SetFlag(SqlParameterFlags.IsNull, (null == _value) || (_value == DBNull.Value) || (HasFlag(SqlParameterFlags.IsSqlParameterSqlType) && _valueAsINullable.IsNull));
                 _udtLoadError = null;
                 _actualSize = -1;
             }
@@ -1012,7 +1012,9 @@ private void CloneHelper(SqlParameter destination)
                 SqlParameterFlags.IsSqlParameterSqlType |
                 SqlParameterFlags.CoercedValueIsDataFeed |
                 SqlParameterFlags.CoercedValueIsSqlType |
-                SqlParameterFlags.ForceColumnEncryption
+                SqlParameterFlags.ForceColumnEncryption |
+                SqlParameterFlags.IsDerivedParameterTypeName
+                // HasScale and HasReceivedMetadata deliberately omitted
             );
             destination._metaType = _metaType;
             destination._collation = _collation;

diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlParameter.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlParameter.cs
@@ -716,7 +716,7 @@ public override object Value
                 _coercedValue = null;
                 _valueAsINullable = _value as INullable;
                 SetFlag(SqlParameterFlags.IsSqlParameterSqlType, _valueAsINullable != null);
-                SetFlag(SqlParameterFlags.IsNull, (null == _value) || (_value == DBNull.Value) || HasFlag(SqlParameterFlags.IsSqlParameterSqlType) && _valueAsINullable.IsNull);
+                SetFlag(SqlParameterFlags.IsNull, (null == _value) || (_value == DBNull.Value) || (HasFlag(SqlParameterFlags.IsSqlParameterSqlType) && _valueAsINullable.IsNull));
                 _udtLoadError = null;
                 _actualSize = -1;
             }
@@ -999,7 +999,9 @@ private void CloneHelper(SqlParameter destination)
                 SqlParameterFlags.IsSqlParameterSqlType |
                 SqlParameterFlags.CoercedValueIsDataFeed |
                 SqlParameterFlags.CoercedValueIsSqlType |
-                SqlParameterFlags.ForceColumnEncryption
+                SqlParameterFlags.ForceColumnEncryption |
+                SqlParameterFlags.IsDerivedParameterTypeName
+                // HasScale and HasReceivedMetadata deliberately omitted
             );
             destination._metaType = _metaType;
             destination._collation = _collation;