Skip to content

Commit

Permalink
Changed non-generic ArrayList of SqlBulkCopy in NetFx to List (#457)
Browse files Browse the repository at this point in the history
  • Loading branch information
Javad authored Mar 11, 2020
1 parent 25447db commit b33df5d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ internal object this[int index]
sealed internal class Result
{
private _SqlMetaDataSet _metadata;
private ArrayList _rowset;
private List<Row> _rowset;

internal Result(_SqlMetaDataSet metadata)
{
this._metadata = metadata;
this._rowset = new ArrayList();
this._rowset = new List<Row>();
}

internal int Count
Expand Down Expand Up @@ -113,15 +113,15 @@ internal void AddRow(Row row)
//
sealed internal class BulkCopySimpleResultSet
{
private ArrayList _results; // the list of results
private List<Result> _results; // the list of results
private Result resultSet; // the current result
private int[] indexmap; // associates columnids with indexes in the rowarray

// c-tor
//
internal BulkCopySimpleResultSet()
{
_results = new ArrayList();
_results = new List<Result>();
}

// indexer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ internal int ObjectID
internal byte[] _bShortBytes = null; // scratch buffer to serialize Short values (2 bytes).
internal byte[] _bDecimalBytes = null; // scratch buffer to serialize decimal values (17 bytes).

//
// DO NOT USE THIS BUFFER FOR OTHER THINGS.
// ProcessHeader can be called ANYTIME while doing network reads.
private byte[] _partialHeaderBuffer = new byte[TdsEnums.HEADER_LEN]; // Scratch buffer for ProcessHeader
Expand Down

0 comments on commit b33df5d

Please sign in to comment.