-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc that explains public VS. Stable releases #345
Conversation
@AArnott out of scope...I did't take a look at code but you can answer quickly...to count height do you check every update of |
To remove the `-prerelease`, the version.json file must be changed to remove it. | ||
Committing this change communicates to everyone looking at the repo that this software is stable. | ||
|
||
The natural evolution of a product includes usually includes entering and exiting a `-prerelease` stage many times, but within a branded release (usually recognized by an intentional version number like "1.2") the progression usually transitions only one direction: from `-prerelease` to stable quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So could be possible have a master always in -beta
and when someone wants release remove beta, do commit generate package and relese and right after re-add -beta
to start a "new pahase"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible, yes, but tedious. It doesn't leave you a branch for servicing that release either.
For this (and I'll add this to the doc), we offer the nbgv prepare-release
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoRossignoli To count height, I walk history by commit from HEAD to the last commit that retains the same |
Yes I wonder only how it's implemented, you walk commit history for version.json file...maybe there was some other trick or you booked ver in some git metadata place, but it's not so. |
Version height calculation starts here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank's!
@AArnott in a case like our where we have 3 components with different version for historical reason we should update version.json like release.branchName = "release_msbuild/v{version}" and run nbgv |
@MarcoRossignoli ugh. I don't know how well that will work or if there's a better way. I've never heard of quite your situation before when using |
Eh at the moment is our use case, because the "core" is shared between 3 "drivers" but not all support all code feature(passing parameters) and "drivers" doesn't provide same "added features", but this is a "design" issue to me, maybe in future we will be able to "merge features" in core and let "drivers" to be only "pluggable entry points". I agree...if we'll decide to "align" version some day maybe will be better. BTW I did some tests on my custom repo, tool and the idea works very well. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.