Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert MSBuildLocator change #338

Closed
wants to merge 2 commits into from
Closed

Revert MSBuildLocator change #338

wants to merge 2 commits into from

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented May 27, 2019

No description provided.

AArnott added 2 commits May 27, 2019 12:45
@AArnott
Remove namespace around test classes
dcb9ac9
@AArnott
Revert PR #334
9399051 
With this PR applied, I can no longer debug unit tests (at least in the BuildIntegrationTests class) because the MSBuildExtensions.LoadMSBuild() method would throw because MSBuild assemblies had already loaded.
@AArnott AArnott mentioned this pull request May 27, 2019
Merged
@AArnott
Copy link
Collaborator Author

AArnott commented May 27, 2019

Hmmm... I'm not sure this fixes it either. With the revert, the local test debugging experience still fails, but with this error:

7: The "Message" task could not be instantiated from the assembly "Microsoft.Build.Tasks, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". Please verify the task assembly has been built using the same version of the Microsoft.Build.Framework assembly as the one installed on your computer and that your host application is not missing a binding redirect for Microsoft.Build.Framework. Unable to cast object of type 'Microsoft.Build.Tasks.Message' to type 'Microsoft.Build.Framework.ITask'.

@AArnott AArnott changed the title Revert MSBuildLocator change and remove namespaces Revert MSBuildLocator change May 27, 2019
@AArnott
Copy link
Collaborator Author

AArnott commented May 27, 2019

Wow, this really is a mess. The MSBuild assemblies that are referenced by the product are all v15.1, yet in the test environment MSBuild.Framework is loaded twice, and the tasks/utilities assemblies that load are 2.0 assemblies. I've definitely got cleanup to do.

@AArnott AArnott closed this May 27, 2019
@AArnott AArnott deleted the dev/andarno/revertPR334 branch May 27, 2019 19:26
@AArnott AArnott restored the dev/andarno/revertPR334 branch August 29, 2019 14:40
AArnott pushed a commit that referenced this pull request Feb 8, 2025
@renovate
Update nbgv and nerdbank.gitversioning updates to 3.7.115 (#338)
b47196d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AArnott