Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgv get-commits doesn't work when version.json specifies x.y.z #340

Closed
AArnott opened this issue May 27, 2019 · 0 comments
Closed

nbgv get-commits doesn't work when version.json specifies x.y.z #340

AArnott opened this issue May 27, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@AArnott
Copy link
Collaborator

AArnott commented May 27, 2019

In a repo where the version.json file specifies three integer versions (moving git height to the 4th position, or even elsewhere like a prerelease tag), the nbgv get-commits command returns no commits when the 4 integer version is specified and the wrong commits for the 3 integer version is given.

We should make this smart enough to interpret the version.json file so it knows how to match a version number as well as possible.

While we're at it, it should not puke when a full semver version is specified (including -prerelease tag).

@AArnott AArnott added the bug label May 27, 2019
@AArnott AArnott self-assigned this May 27, 2019
@AArnott AArnott added this to the 3.0 milestone May 28, 2019
@AArnott AArnott closed this as completed May 28, 2019
AArnott pushed a commit that referenced this issue Feb 8, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant