Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bold with headings in breaking changes pages #2774

Merged
merged 4 commits into from
Oct 17, 2020
Merged

Conversation

roji
Copy link
Member

@roji roji commented Oct 15, 2020

Keep the linter happy at all costs

@roji
Copy link
Member Author

roji commented Oct 15, 2020

Also reduced heading level to make the breaking changes appear in the right-hand contents pane, do we like?

@roji roji requested a review from a team October 15, 2020 16:29
@AndriySvyryd
Copy link
Member

The right-hand pane is pretty much unusable with this

@roji
Copy link
Member Author

roji commented Oct 15, 2020

I thought it was useful to have the list, but can info they part of it seems bad.

@AndriySvyryd
Copy link
Member

Perhaps just group them by impact?

@roji
Copy link
Member Author

roji commented Oct 15, 2020

I'll give it a go.

@roji roji force-pushed the SomeBoldHeadings branch from fcb649a to 8fe3f1c Compare October 16, 2020 07:06
@roji
Copy link
Member Author

roji commented Oct 16, 2020

Done, looks pretty nice IMHO

@roji roji merged commit c2721ec into master Oct 17, 2020
@smitpatel smitpatel deleted the SomeBoldHeadings branch October 17, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants