Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for naming a container when using CreateContainer #7

Merged
merged 2 commits into from
Oct 7, 2014

Conversation

jgarverick
Copy link
Contributor

Updated commit that should be based on rebase to current master, then applying just the file changes. I'm not worried about the Nuspec changes as they won't work without altering more things at a csproj level.

@ahmetb
Copy link
Contributor

ahmetb commented Oct 6, 2014

Thanks!

  • Have you tested this manually?

I have just noticed that there's a new parameter called RestartPolicy (#8) and we just use .Config field in there right now. I'm not sure if we have other instances where one property bag type (xxxParameters) contains mixed "query strings" (i.e. name) and "request body parameters" (i.e config).

@jgarverick
Copy link
Contributor Author

I have. I'm using it in my POC right now and it works like a champ. I can
move it into the config object if you want. I separated it only because it
wasn't listed as part of the config, but given the QueryStringParameter
usage I should be able to make it work.

On Monday, October 6, 2014, Ahmet Alp Balkan [email protected]
wrote:

Thanks! Have you tested this manually?

I have just noticed that there's a new parameter called RestartPolicy (#8
#8) and we just
use .Config field in there right now. I'm not sure if we have another
instances where one object (xxxParameters) contains mixed "query strings"
(i.e. name) and "request body parameters" (i.e config).


Reply to this email directly or view it on GitHub
#7 (comment)
.

@jgarverick
Copy link
Contributor Author

The rest of your requests should be all set. I tested this out locally with my own application and was able to create a named container. I'm assuming we should be all set on this one, and I'll create a separate pull for the other item.

ahmetb pushed a commit that referenced this pull request Oct 7, 2014
Adding support for naming a container when using CreateContainer
@ahmetb ahmetb merged commit 044ac99 into dotnet:dev Oct 7, 2014
@ahmetb ahmetb added this to the v1.1.1 milestone Oct 7, 2014
@jgarverick jgarverick deleted the NamedContainers branch October 22, 2014 12:46
ahmetb pushed a commit that referenced this pull request Apr 27, 2016
Fixing a few bugs in the generated code types.
robborden pushed a commit to Coinigy/Docker.DotNet that referenced this pull request Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants