Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#590): Do not pull non existing images in monitor event unit tests #591

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix(#590): Do not pull non existing images in monitor event unit tests #591

merged 1 commit into from
Sep 23, 2022

Conversation

HofmeisterAn
Copy link
Contributor

No description provided.

@HofmeisterAn
Copy link
Contributor Author

@aDisplayName @galvesribeiro I think this is better. We do not need to pull images (that do not exist) to test the monitor event API.

galvesribeiro
galvesribeiro approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvesribeiro galvesribeiro merged commit 30181cc into dotnet:master Sep 23, 2022
@HofmeisterAn HofmeisterAn deleted the bugfix/remove-unnecessary-createimageasync branch September 23, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvesribeiro galvesribeiro galvesribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HofmeisterAn @galvesribeiro