Strong name the assemblies #567
Conversation
|
@galvesribeiro can you review this please? |
|
@galvesribeiro is it possible to get this included in the next release please? |
There was a problem hiding this comment.
@galvesribeiro I think we can merge this. Not having the strong name prevents .NET Framework projects using the library in some cases.
|
@galvesribeiro Can we merge this, please? |
|
Ok. Got it. I thought SN wasn't a requirement on current .Net framework versions and only old ones used it. It is important to make clear that this library, after the refactory in the works, will only support the supported versions of .Net. Anything out of support policy will not be included. For now, lets merge this. Thanks! |
Why is that? Are there any requirements or reasons to retarget from .NET Standard to .NET 5+? Do we really need the runtime features and drop support for .NET Framework? The .NET Framework 4.6.2 EOL is 2027 (4.8.1 TBD) wich in theory supports .NET Standard 2.0. In general. I am fine with .NET 5+, but we exclude developers from using Docker.DotNet then (something I would like to avoid). |
|
Yeah sorry. That is what I meant. If that is a supported version so be it.
In the other hand, when/if the TFMs are really simplified for net8 ownward, that will remove the old frameworks.
Anyway, nothing changes now. It is just a heads up that we will not hold back because of old .net framework.
…Sent from my iPhone
On Dec 4, 2022, at 6:24 AM, Andre Hofmeister ***@***.***> wrote:
It is important to make clear that this library, after the refactory in the works, will only support the supported versions of .Net. Anything out of support policy will not be included.
Why is that? Are there any requirements or reasons to retarget from .NET Standard to .NET 5+? Do we really need the runtime features and drop support for .NET Framework? The .NET Framework 4.6.2 EOL is 2027 (4.8.1 TBD) wich in theory supports .NET Standard 2.0.
In general. I am fine with .NET 5+, but we exclude developers from using Docker.DotNet then (something I would like to avoid).
—
Reply to this email directly, view it on GitHub<#567 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABD64OBTXOPZRRLPGSVS5TLWLRPM7ANCNFSM52HO4YEA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Blocks the OpenTelemetry in .NET folks from using it... |
|
@HofmeisterAn just to clarify, the lack of this change being released is blocking you? |
Yep, breaks the OTel build: |
|
Sorry for all the delay. Spoke on Slack with @HofmeisterAn. The new package was pushed which include the strong naming as per this PR. Will discuss next steps from there. Thanks! |
Key generated using
sn -k Key.snkCloses #403