Add taskbar progress

[timcassell]

I initially tried to use a nuget package, but it does not support netstandard2.0. So I copied the relevant code from https://github.com/contre/Windows-API-Code-Pack-1.1 to Helpers/Taskbar to get this working (thanks @contre and @aybe).

Also thanks to ivan_pozdeev on StackOverflow for grabbing the proper console window handle.

[adamsitnik]

The screen shot that you have provided looks very promising, but how about the license? Can we just copy paste the code?

@timcassell thank you for your contribution!

[timcassell]

@adamsitnik The license: https://github.com/contre/Windows-API-Code-Pack-1.1/blob/master/LICENSE

I was reading about it, apparently it was originally written by Microsoft a while ago and then they disappeared it, and other people picked up the code and uploaded to nuget (Source). So I don't think the license is an issue, but I'm no legal expert. ;)

Also, your change request makes sense, I'll do that.

[timcassell]

In the future we could even use this to alert warnings or errors if we want.

[Khaos66]

I just commented on #2102. You don't need another NuGet. This is a simple ComImport.
P.S. feel free to copy my code

[timcassell]

Thanks @Khaos66! I implemented your code, it's so much less than I had before!

[adamsitnik]

The code looks good to me, but I've tested it and it does not work on my Windows 10 and 11 machines, both using cmd and Windows Terminal:

[timcassell]

@adamsitnik I pushed a change to get the console window's ancestor. Unfortunately, I only have a Win7 machine to test on, so could you let me know if that fixes it?

[adamsitnik]

@timcassell I've given it a try and it does not work.

I've followed https://dzone.com/articles/using-windows-78-taskbar and created a small console app using https://www.nuget.org/packages/Microsoft-WindowsAPICodePack-Shell:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.WindowsAPICodePack-Shell" Version="1.1.0" />
  </ItemGroup>
</Project>

using Microsoft.WindowsAPICodePack.Taskbar;
using System.Threading;

namespace TaskbarProgress
{
    internal class Program
    {
        static void Main(string[] args)
        {
            if (TaskbarManager.IsPlatformSupported)
            {
                TaskbarManager tbManager = TaskbarManager.Instance;

                for (int i = 0; i < 100; i++)
                {
                    tbManager.SetProgressValue(i, 100);

                    Thread.Sleep(100);
                }
            }
        }
    }
}

it fails as well...

Unhandled exception. System.InvalidOperationException: A valid active Window is needed to update the Taskbar.
   at Microsoft.WindowsAPICodePack.Taskbar.TaskbarManager.get_OwnerHandle()
   at Microsoft.WindowsAPICodePack.Taskbar.TaskbarManager.SetProgressValue(Int32 currentValue, Int32 maximumValue)
   at TaskbarProgress.Program.Main(String[] args) in C:\Users\adsitnik\source\repos\TaskbarProgress\Program.cs:line 18

I am sorry but I don't have more time to spend on this.

[timcassell]

@adamsitnik I got the same error when I was testing initially, which was why I found it necessary to call the GetConsoleWindow(). This was the code I had working:

using Microsoft.WindowsAPICodePack.Taskbar;
using System;
using System.Runtime.InteropServices;
using System.Threading;

namespace TaskbarProgress
{
    internal class Program
    {
        [DllImport("kernel32.dll")]
        private static extern IntPtr GetConsoleWindow();

        static void Main(string[] args)
        {
            if (TaskbarManager.IsPlatformSupported)
            {
                IntPtr consoleWindowHandle = GetConsoleWindow();
                TaskbarManager tbManager = TaskbarManager.Instance;

                tbManager.SetProgressState(TaskbarProgressBarState.Normal, consoleWindowHandle);
                for (int i = 0; i < 100; i++)
                {
                    tbManager.SetProgressValue(i, 100, consoleWindowHandle);

                    Thread.Sleep(100);
                }
                tbManager.SetProgressState(TaskbarProgressBarState.NoProgress, consoleWindowHandle);
            }
        }
    }
}

I am sorry but I don't have more time to spend on this.

Understandable. I might be able to get my hands on a win 11 machine in a couple days.

[Khaos66]

Strange. I used this code on all of the windowses. Win 7, 8, 10, 11.
You need the right window handle however. I've not used it with a console app before. Sorry

[adamsitnik]

You need the right window handle however.

That is correct. I saw that all the sys-calls are succeeding (returning 0), but we are most likely using the wrong window handle.

[timcassell]

I was able to see it working in both cmd and PowerShell on Win11, but it doesn't work with Terminal. Not sure why, I even tried walking the GetAncestor with Parent flag until I hit the Desktop window, but still no luck. We might be able to get it to work by pushing an actual Terminal command for it, but not sure if we want to do that (or if we can even detect that we're running in Terminal). microsoft/terminal#3004

Also, Win11 is weird, when I report 0 progress, it fills the whole bar instead of having an empty bar (Win7 doesn't do this). So I left the state as Indeterminate until the first benchmark is done.

[Khaos66]

Yes win11 does that so you know that the window is open. Because no bar unter the icon means the app is pinned to the taskbar but not running ;)

I guess that Windows Terminal uses sub-processes instead of embedded windows. It could just redirect all inputs/outputs for you.
You might want to check the parent process instead of the parent window?
Still, I'm not an expert here, it's just a guess

[timcassell]

Thanks to help from folks on the Windows Terminal repo, I was able to make it work. It now works for shells hosted in both old conhost and Windows Terminal.

[adamsitnik]

It looks and works great, thank you @timcassell !

You should consider writing a blog post about hot to get it working for Windows 7 + 11 since we were both unable to find any solution on the internet.