Android version improvements #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
May 24, 2018 20:24
Android 4.0 was the first version that stopped supporting ARMv5 devices, making armeabi libraries unnecessary. Also NDK r17 removed the armeabi support anyway, so the app can't be even synchronized with Gradle, let alone compiled.
…were also updated accordingly.
…mount of code. Also fixed potential null pointer exceptions.
… older versions, on 3rd party launchers that support adaptive icons). Also compressed both old and new launcher PNGs for smaller size.
This gets rid of an unnecessary overdraw, making drawing this activity slightly faster.
…oing to background.
This should save ~0.1 MB from the APK.
noxytrux
reviewed
Jun 2, 2018
| @@ -14,7 +14,7 @@ void AndroidTimer::update() { | |||
|
|
|||
| timespec lTimeVal; | |||
|
|
|||
| #ifdef __EMSCRIPTEN__ | |||
| #if defined(__EMSCRIPTEN__) || defined (__ANDROID__) | |||
There was a problem hiding this comment.
this is not entirely right MONOTONIC will work good on Emulator but not on actual device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various improvements and fixes to the Android version, including: