Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios to 1.6.7 #321

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Update axios to 1.6.7 #321

merged 2 commits into from
Mar 1, 2024

Conversation

surc54
Copy link
Contributor

@surc54 surc54 commented Nov 23, 2023

This PR updates the axios package to 1.6.7, which should resolve the following vulnerability issue: GHSA-wf5p-g6vw-rhxx

I don't believe the project is affected by this -- I just wanted the warning on my side gone 😄

One thing: I was following the contribution guidelines but I could not get the tests to run properly, even on master. Am I missing something?

@surc54 surc54 marked this pull request as ready for review November 23, 2023 00:06
@nikolay
Copy link

nikolay commented Feb 23, 2024

Maybe upgrade to the latest v1.6.7 instead?

@nikolay
Copy link

nikolay commented Feb 23, 2024

@motdotla Can you please review this as it's a security issue? Many thanks for considering my request.

@surc54 surc54 changed the title Update axios to 1.6.2 Update axios to 1.6.7 Feb 23, 2024
@BradyRyun
Copy link

@motdotla We also would like to see this added as we are going through security reviews.

@nikolay
Copy link

nikolay commented Mar 1, 2024

I will email @motdotla, because it doesn't seem he gets notified on our mentions.

@motdotla
Copy link
Member

motdotla commented Mar 1, 2024

i do. will get to this soon everyone. apologies. work on dotenvx has been our recent focus.

@motdotla motdotla merged commit 3870884 into dotenv-org:master Mar 1, 2024
@motdotla
Copy link
Member

motdotla commented Mar 1, 2024

released as v1.26.1

@surc54 surc54 deleted the update-axios branch March 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants