-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve life cycle hooks typings #8652
Merged
saihaj
merged 4 commits into
dotansimha:master
from
CodepenCreativeChallenge:feature/simpler-hook-types
Dec 6, 2022
Merged
improve life cycle hooks typings #8652
saihaj
merged 4 commits into
dotansimha:master
from
CodepenCreativeChallenge:feature/simpler-hook-types
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1cb681 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
saihaj
reviewed
Nov 25, 2022
saihaj
requested changes
Nov 28, 2022
Co-authored-by: Saihajpreet Singh <[email protected]>
saihaj
approved these changes
Nov 28, 2022
This was referenced Nov 29, 2022
sorry for the delay here |
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to prepare a PR for #8643.
Right now the life cycle hooks are using generics and reducers which kind of blocks an easy implementation.
Therefore I removed the reducer and the generic type.
Related #8643
Type of change
Please delete options that are not relevant.
Checklist: