Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in template file resolutions #110

Merged
merged 1 commit into from
Jun 25, 2017

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Jun 24, 2017

Currently when trying to run the multi-file typescript setup the user gets the following error:

(node:94403) UnhandledPromiseRejectionWarning: Unhandled promise rejection 
  (rejection id: 1): 
    Error: Template file /home/<user>/generators/type....index.handlebars does not exist

This issue is because the generator path wasn't being resolved as the config.js path was.

@codecov-io
Copy link

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   42.49%   42.49%           
=======================================
  Files          20       20           
  Lines         506      506           
  Branches       94       94           
=======================================
  Hits          215      215           
  Misses        291      291
Impacted Files Coverage Δ
src/engine/templates.ts 45.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157fae5...278b3d7. Read the comment docs.

@zephraph zephraph changed the title fix generator file resolution Fix error in template file resolutions Jun 24, 2017
@dotansimha dotansimha merged commit 5197b47 into dotansimha:master Jun 25, 2017
@dotansimha
Copy link
Owner

Thanks @zephraph !

@yohcop
Copy link

yohcop commented Jul 13, 2017

Hi! Could a new release be pushed with this fix? Thanks a lot!

@dotansimha
Copy link
Owner

@yohcop done :) please try 0.5.5

@yohcop
Copy link

yohcop commented Jul 13, 2017

Thanks for the really quick answer! All good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants