Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix case of reading from closed socket #168

Merged
merged 2 commits into from
Oct 20, 2021
Merged

fix case of reading from closed socket #168

merged 2 commits into from
Oct 20, 2021

Conversation

ohadshai
Copy link
Collaborator

add listening event
fix case of reading from closed socket

@ohadshai ohadshai requested a review from doronz88 October 20, 2021 08:29
doronz88
doronz88 requested changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the two commits as follows to fit into out commit conventions:

  • tcp_forwarder: bugfix: validation of closed sockets within _handle_data
  • tcp_forwarder: add listening event for threading purposes

@ohadshai ohadshai force-pushed the bugfix/tcp_forwarder_reading_closed_sockets branch from afd7593 to fd9fad9 Compare October 20, 2021 10:16
@doronz88 doronz88 merged commit 1e6340f into master Oct 20, 2021
@doronz88 doronz88 deleted the bugfix/tcp_forwarder_reading_closed_sockets branch October 20, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronz88 doronz88 doronz88 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohadshai @doronz88