Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: afc: add -i/--ignore-errors option to pull #1281

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

0xepsil0n
Copy link
Contributor

No description provided.

@0xepsil0n 0xepsil0n changed the title Do not interrupt the copy if an error occurs (AFC) Do not interrupt the copy if an error occurs Nov 15, 2024
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring all possible errors should not be considered a good practice. Let's instead use an optional ignore_errors: bool = False to the pull() method.

@0xepsil0n
Copy link
Contributor Author

Ignoring all possible errors should not be considered a good practice. Let's instead use an optional ignore_errors: bool = False to the pull() method.

Done!

@0xepsil0n
Copy link
Contributor Author

0xepsil0n commented Nov 17, 2024

Is there any way I can run those tests offline before pushing them?

@doronz88
Copy link
Owner

@0xepsil0n yeah you can install the pre-commit hook before committing.

python3 -m pip install pre-commit
pre-commit install

@doronz88 doronz88 changed the title (AFC) Do not interrupt the copy if an error occurs cli: afc: add -i/--ignore-errors option to pull Nov 18, 2024
@doronz88 doronz88 merged commit b2b7b9d into doronz88:master Nov 18, 2024
17 checks passed
@doronz88
Copy link
Owner

Thanks for the contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants