Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha-json usage instructions #145

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Update mocha-json usage instructions #145

merged 1 commit into from
Jun 25, 2024

Conversation

MonkeyDo
Copy link
Contributor

With mocha#4607 fixed and published in v9.1.0, users can output valid json using mocha's JSON reporter and the --reporter-option output={filename} option, provided version 9.1.0 or above is used.

This PR updates the readme to reflect this.

@IanMoroney
Copy link
Contributor

IanMoroney commented Feb 22, 2022

@MonkeyDo , I ran into a similar issue as yourself where there were features that I needed from this project and looked like it wasn't being updated any time soon, so I took the initiative to fork the project myself and build the enhancements into it with a colleague.
I have also now taken this PR and added the contents into that repo so you can use them :)

https://github.com/phoenix-actions/test-reporting/
https://github.com/marketplace/actions/test-reporting

@jozefizso
Copy link
Collaborator

This PR look legit. I would say we may keep the mocha 9 instructions only.

The mocha 7 is for NodeJS 8 and mocha 9 for NodeJS 12+.

People using the mocha 7 can still get back to old instructions in the repo history.

@jozefizso jozefizso added the documentation Improvements or additions to documentation label Dec 18, 2023
@jozefizso jozefizso self-assigned this Dec 31, 2023
@abenhamdine
Copy link

abenhamdine commented Jan 24, 2024

This PR look legit. I would say we may keep the mocha 9 instructions only.

The mocha 7 is for NodeJS 8 and mocha 9 for NodeJS 12+.

People using the mocha 7 can still get back to old instructions in the repo history.

mocha 10.2.0 has been published 1 year ago, I think it's time indeed to provide the "new" configuration --reporter-option output={filename}
I just set up a worfklow with mocha and I can confirm it works perfectly.

@jozefizso jozefizso added this to the v2.0.0 milestone Jun 25, 2024
@jozefizso jozefizso merged commit 101b537 into dorny:main Jun 25, 2024
@MonkeyDo MonkeyDo deleted the monkeydo-mocha-json-usage branch June 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants