Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert exporter chart to use k8s deployments instead of openshift... #1159

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented Sep 9, 2024

…deploymentconfigs, which are deprecated

Linked Issues

resolves #1147

Description

  • Converted exporter helm chart to deploy using kubnetes Deployments instead of depcrecated OpenShift DeploymentConfigs
  • Renamed the _deploymentconfig.yaml file to _deployment.yaml
  • Updated helper scripts with changed file name

Testing Instructions

Install operator from PR build, and create a test pelorus CR instance. See that exporters deploy successfully, and that they show up on the "Deployments" page in the web console instead of "DeploymentConfigs".

…deploymentconfigs, which are deprecated

Signed-off-by: Eric Sauer <[email protected]>
@etsauer etsauer force-pushed the exporter-deployments branch from 5953b89 to 1922295 Compare September 9, 2024 19:50
Copy link

github-actions bot commented Sep 9, 2024

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1159-a8586cd \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

Copy link

github-actions bot commented Sep 9, 2024

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1159-c0385c6 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

Copy link

github-actions bot commented Sep 9, 2024

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1159-6e6efa7 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1159-27dadfa \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

Copy link

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1159-bce9e17 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

@etsauer
Copy link
Collaborator Author

etsauer commented Sep 10, 2024

/trickortreat

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@etsauer
Copy link
Collaborator Author

etsauer commented Sep 10, 2024

/override ci/prow/4.13-e2e-openshift

Copy link

openshift-ci bot commented Sep 10, 2024

@etsauer: Overrode contexts on behalf of etsauer: ci/prow/4.13-e2e-openshift

In response to this:

/override ci/prow/4.13-e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cgruver
Copy link
Collaborator

cgruver commented Sep 10, 2024

/approve

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgruver

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgruver cgruver merged commit 18be149 into master Sep 10, 2024
20 checks passed
@cgruver cgruver deleted the exporter-deployments branch September 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert exporter DeploymentConfigs to Deployments
2 participants