DynamicObject&DynamicArray can be shared between runtimes #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dop251 Is there anything wrong with this code that needs to be improved? |
|
See the mentioned commit. It should provide the functionality you're after. Let me know if there is any problem. |
|
Sorry, I just saw close pr on my phone just now, but I didn't see you commit the code. Now it seems to meet my current needs. thanks. |
Gabri3l
pushed a commit
to mongodb-forks/goja
that referenced
this pull request
Sep 1, 2022
Gabri3l
added a commit
to mongodb-forks/goja
that referenced
this pull request
Mar 22, 2023
* Implemented classes (including private elements). Closes dop251#349. * Fixed "delete 'a'.prop". Optimised a[<const_string>] to a.<const_string> * Enabled more tests and fixed some bugs. Closes dop251#410. * Fixed this binding initialisation. Fixes dop251#415. * Added NewSharedDynamicObject() and NewSharedDynamicArray(). Closes dop251#418. * Optimised memory usage when generating function and class initialisation code * Fixed Export() value for arrow functions and classes. Added Runtime.AssertConstructor. Closes dop251#419. * Always create a map when exporting. Fixes dop251#422. * Refactored conversion to primitive. Always use `String()` method if defined. Closes dop251#423.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a complex and large json read-only object that needs to be shared between each runtime to save memory and cpu usage. Now I made some changes to make DynamicObject/DynamicArray implement this function