Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hook #618

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Pre-commit hook #618

merged 2 commits into from
Jan 26, 2024

Conversation

lbiaggi
Copy link
Contributor

@lbiaggi lbiaggi commented Jan 13, 2024

Create a doorstop pre-commit hook

Copy link
Collaborator

@neerdoc neerdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I already see a use of adding another check for PRs that verify that all changed code has test coverage.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f34c454) 95.50% compared to head (ddbe061) 95.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
- Coverage    95.50%   95.40%   -0.10%     
===========================================
  Files           41       41              
  Lines         5053     5053              
  Branches      1184     1184              
===========================================
- Hits          4826     4821       -5     
- Misses         143      147       +4     
- Partials        84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neerdoc neerdoc merged commit eec59a5 into doorstop-dev:develop Jan 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants