go/ir: do not panic on generic type slice expression #1271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not add a regression test, because I am not sure what testdata directory is related to |
No worries. go/ir doesn't have great regression tests to begin with, and mostly relies on the fact that someone will complain if it starts crashing again… Thanks for the PR. |
dominikh
pushed a commit
that referenced
this pull request
May 16, 2022
Closes: gh-1270 Closes: gh-1271 [via git-merge-pr] Co-authored-by: Dominik Honnef <[email protected]> (cherry picked from commit 67bbe3d)
dominikh
pushed a commit
that referenced
this pull request
May 16, 2022
Closes: gh-1270 Closes: gh-1271 [via git-merge-pr] Co-authored-by: Dominik Honnef <[email protected]> (cherry picked from commit 67bbe3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1270.