Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch all versions of mocha loaded, not just the first one discovered. #25

Merged
merged 1 commit into from
Dec 15, 2013

Conversation

nowells
Copy link
Contributor

@nowells nowells commented Dec 10, 2013

In a Node environment, when you have multiple versions of mocha, say grunt-mocha-webdriver and grunt-mocha-test, mocha-as-promised does not always duck punch the correct mocha module, so this ensures that all loaded mocha modules are duck punched.

@nowells
Copy link
Contributor Author

nowells commented Dec 10, 2013

@domenic if you are amenable to this goal and approach I am happy to take on fleshing out tests for this, just let me know.

@ttdmayshark
Copy link

👍

@domenic
Copy link
Owner

domenic commented Dec 10, 2013

Looks good to me. If you have an idea on how to write tests, please do...

@nowells
Copy link
Contributor Author

nowells commented Dec 10, 2013

@domenic would it make sense to merge this as is and bump a release sooner while I tease out how best to test? or would you rather wait until I get that worked out?

@domenic
Copy link
Owner

domenic commented Dec 10, 2013

I'll probably merge this and publish within the next day or two, when I have some spare open-source time after work.

@nowells
Copy link
Contributor Author

nowells commented Dec 10, 2013

thanks @domenic

@domenic domenic merged commit 04f3b88 into domenic:master Dec 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants