Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use already existing regexes #186

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: use already existing regexes #186

wants to merge 4 commits into from

Conversation

fzipi
Copy link
Contributor

@fzipi fzipi commented Jan 11, 2025

what

  • use already existing regex to match for s3-website
  • move methods from manual scan to common utils

why

  • fix code security

references

@fzipi fzipi requested review from a team as code owners January 11, 2025 22:59
@fzipi fzipi force-pushed the fix/code-scanning-alerts branch from ec9e447 to c2c4727 Compare January 11, 2025 23:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2025 •
edited
Loading

Integration Test Results - Manual Scans

14 tests  ±0   14 ✅ ±0   6s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 69c63b2. ± Comparison against base commit a775b77.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2025 •
edited
Loading

Test Results

79 tests  ±0   79 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 69c63b2. ± Comparison against base commit a775b77.

♻️ This comment has been updated with latest results.

@fzipi
fix: use already existing regexes
4e4e8c7 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the fix/code-scanning-alerts branch from c2c4727 to 4e4e8c7 Compare January 11, 2025 23:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

Integration Test Results - Deployment

2 tests   2 ✅  1m 26s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 7658a60.

♻️ This comment has been updated with latest results.

paulschwarzenberger
paulschwarzenberger reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@paulschwarzenberger paulschwarzenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline comments

lambda_code/takeover/takeover.py Show resolved Hide resolved
lambda_code/scan/scan.py Show resolved Hide resolved
fzipi
fzipi commented Jan 13, 2025
View reviewed changes
Copy link
Contributor Author

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include period at the end.

utils/utils_aws.py Outdated Show resolved Hide resolved
utils/utils_aws.py Outdated Show resolved Hide resolved
@fzipi fzipi force-pushed the fix/code-scanning-alerts branch from 217229a to 7658a60 Compare January 13, 2025 11:03
@fzipi
Copy link
Contributor Author

fzipi commented Jan 14, 2025

This is weird, as regex is capturing the domains in the test perfectly: https://regex101.com/r/dDflkN/1

@fzipi fzipi force-pushed the fix/code-scanning-alerts branch from f44c7c3 to 69c63b2 Compare February 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschwarzenberger paulschwarzenberger paulschwarzenberger left review comments

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzipi @nitrocode @paulschwarzenberger