Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax for drop temporary table ... #395

Merged
merged 4 commits into from
Jan 23, 2025
Merged

syntax for drop temporary table ... #395

merged 4 commits into from
Jan 23, 2025

Conversation

jycor
Copy link

@jycor jycor commented Jan 22, 2025

No description provided.

@jycor jycor requested a review from zachmu as a code owner January 22, 2025 21:17
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exists = true
}
tableNames := $4.(TableNames)
var neTemp bool
if $2.(int) != 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to put these in symbol order

input: "DROP TABLE `dual`",
output: "drop table `dual`",
},
{
input: "DROP TEMPORARY TABLE `dual`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test combining with IF EXISTS

@jycor jycor merged commit 3b45b8c into main Jan 23, 2025
4 checks passed
@jycor jycor deleted the james/temp branch January 23, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants