Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Get rid of globals for setting a protocol listener factory. Get rid of unused, global-ridden and complicated Interceptor and Option functionality. #2879

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Mar 5, 2025

No description provided.

@reltuk reltuk requested a review from zachmu March 5, 2025 20:33
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody at one point had built against the Interceptor (community contribution), so it's not actually unused. Can we keep it around and encapsulate its global state?

@reltuk
Copy link
Contributor Author

reltuk commented Mar 5, 2025

Somebody at one point had built against the Interceptor (community contribution), so it's not actually unused. Can we keep it around and encapsulate its global state?

That is to say, it's nice to keep the functionality, but it's OK if we make the code backwards incompatible so the integrator needs to update to maintain their own chain variable or whatever when constructing the handler?

@reltuk reltuk force-pushed the aaron/server-protocol-listener-fixup branch from 46d0287 to 1a65d1c Compare March 5, 2025 22:12
@reltuk
Copy link
Contributor Author

reltuk commented Mar 5, 2025

Fixing DoltgreSQL integration requires a Dolt bump where it exposes ProtocolListenerFactory in sqlserver.ConfigureServices. It's not a big lift, but I'll be working it through after this lands.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reltuk reltuk merged commit 14a57e0 into main Mar 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants