Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle user variables in load data #2656

Merged
merged 7 commits into from
Sep 12, 2024
Merged

handle user variables in load data #2656

merged 7 commits into from
Sep 12, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 11, 2024

This PR adds support for assigning user variables within a LOAD DATA query, and referencing user variables withing an expression for SET clauses within the same LOAD DATA query.

Additionally, this PR refactors much of the LOAD DATA code.
We also moved GetField indexing out of iterator and into analyzer

fixes: dolthub/dolt#8307

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jycor jycor merged commit 87cdecf into main Sep 12, 2024
8 checks passed
@jycor jycor deleted the james/uservars branch September 12, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load data error
2 participants